Cast RLIM_INFINITY to rlim_t to fix 64-bit Solaris 10 build

Message ID yddsh28nt7i.fsf@CeBiTec.Uni-Bielefeld.DE
State New
Headers show
Series
  • Cast RLIM_INFINITY to rlim_t to fix 64-bit Solaris 10 build
Related show

Commit Message

Rainer Orth Sept. 17, 2018, 1:34 p.m.
gdb doesn't currently build on 64-bit Solaris 10:

/vol/src/gnu/gdb/hg/master/local/gdb/utils.c: In function ‘void dump_core()’:
/vol/src/gnu/gdb/hg/master/local/gdb/utils.c:223:55: error: narrowing conversion
 of ‘-3’ from ‘long int’ to ‘rlim_t’ {aka ‘long unsigned int’} inside {
} [-Wnarrowing]
   struct rlimit rlim = { RLIM_INFINITY, RLIM_INFINITY };
                                                       ^
/vol/src/gnu/gdb/hg/master/local/gdb/utils.c:223:55: error: narrowing conversion
 of ‘-3’ from ‘long int’ to ‘rlim_t’ {aka ‘long unsigned int’} inside {
} [-Wnarrowing]

This was introduced by 

2018-08-27  Tom Tromey  <tom@tromey.com>

	PR build/23087:
	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Remove -Wno-narrowing.

and can be fixed by the following patch.

Solaris 11 isn't affected because there <sys/resource.h> has

#define	RLIM_INFINITY	((rlim_t)-3l)

instead of

#define RLIM_INFINITY   (-3l)

on Solaris 10.

Tested on amd64-pc-solaris2.10 and amd64-pc-solaris2.11.  Ok for master?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2018-09-17  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* utils.c (dump_core) [HAVE_SETRLIMIT]: Cast RLIM_INFINITY to
	rlim_t.

Comments

Tom Tromey Sept. 17, 2018, 1:41 p.m. | #1
>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:


Rainer> 2018-09-17  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

Rainer> 	* utils.c (dump_core) [HAVE_SETRLIMIT]: Cast RLIM_INFINITY to
Rainer> 	rlim_t.

This is ok.  Thank you for fixing this.

Tom

Patch

# HG changeset patch
# Parent  e76ee5ead0d6305ffdac7965cf62a7b8b1ae5d36
Cast RLIM_INFINITY to rlim_t to fix 64-bit Solaris 10 build

diff --git a/gdb/utils.c b/gdb/utils.c
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -220,7 +220,7 @@  void
 dump_core (void)
 {
 #ifdef HAVE_SETRLIMIT
-  struct rlimit rlim = { RLIM_INFINITY, RLIM_INFINITY };
+  struct rlimit rlim = { (rlim_t) RLIM_INFINITY, (rlim_t) RLIM_INFINITY };
 
   setrlimit (RLIMIT_CORE, &rlim);
 #endif /* HAVE_SETRLIMIT */