RS6000/BFD: Remove dead duplicate `config.bfd' target matchers

Message ID alpine.LFD.2.21.1809151810360.23252@eddie.linux-mips.org
State New
Headers show
Series
  • RS6000/BFD: Remove dead duplicate `config.bfd' target matchers
Related show

Commit Message

Maciej W. Rozycki Sept. 15, 2018, 10:24 p.m.
Remove duplicate `rs6000-*-aix5.[01]' and `rs6000-*-aix[5-9]*' target 
configuration selectors meant to correspond to `powerpc64-*-aix5.[01]' 
and `powerpc64-*-aix[5-9]*' respectively for the purpose of BFD target 
vector selection in `config.bfd'. 

These selectors were added with commit 9a9e2ca33263 ("rs6000 xcoff bfd 
config"), <https://sourceware.org/ml/binutils/2010-12/msg00372.html>, 
and have been dead right from the beginning, because they appear twice 
each in the case statement, which means the earlier instance of each 
takes precedence and the other one is ignored.  Here ones that alias to 
`powerpc-*-aix5.[01]' and `powerpc-*-aix[5-9]*' respectively immediately 
above are used instead.

	bfd/
	* config.bfd <rs6000-*-aix5.[01], rs6000-*-aix[5-9]*>: Remove
	duplicate `case' selectors.
---
Hi Alan,

 I've spotted this by chance while looking into the XFAIL list for the 
SEGMENT_START test case and it looks to me like a plain oversight.  If 
there's something that I missed, then I'll be happy to get enlightened.

 Otherwise, OK to apply?

  Maciej
---
 bfd/config.bfd |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

binutils-rs6000-bfd-config.diff

Comments

Alan Modra Sept. 16, 2018, 12:40 p.m. | #1
On Sat, Sep 15, 2018 at 11:24:56PM +0100, Maciej W. Rozycki wrote:
> 	* config.bfd <rs6000-*-aix5.[01], rs6000-*-aix[5-9]*>: Remove

> 	duplicate `case' selectors.


OK, thanks.

-- 
Alan Modra
Australia Development Lab, IBM
Maciej W. Rozycki Sept. 20, 2018, 2:54 p.m. | #2
On Sun, 16 Sep 2018, Alan Modra wrote:

> > 	* config.bfd <rs6000-*-aix5.[01], rs6000-*-aix[5-9]*>: Remove

> > 	duplicate `case' selectors.

> 

> OK, thanks.


 Applied, thanks for your review.

  Maciej

Patch

Index: src/bfd/config.bfd
===================================================================
--- src.orig/bfd/config.bfd
+++ src/bfd/config.bfd
@@ -1066,7 +1066,7 @@  case "${targ}" in
     want64=true
     ;;
 #ifdef BFD64
-  powerpc64-*-aix5.[01] | rs6000-*-aix5.[01])
+  powerpc64-*-aix5.[01])
     targ_defvec=rs6000_xcoff64_aix_vec
     targ_selvecs="rs6000_xcoff_vec"
     want64=true
@@ -1079,7 +1079,7 @@  case "${targ}" in
     want64=true
     ;;
 #ifdef BFD64
-  powerpc64-*-aix[5-9]* | rs6000-*-aix[5-9]*)
+  powerpc64-*-aix[5-9]*)
     targ_cflags=-DAIX_WEAK_SUPPORT
     targ_defvec=rs6000_xcoff64_aix_vec
     targ_selvecs="rs6000_xcoff_vec"