provide type_align gdbarch function for nios2

Message ID 7428fb6b-bd85-f852-41a4-683e4bea16ee@codesourcery.com
State New
Headers show
Series
  • provide type_align gdbarch function for nios2
Related show

Commit Message

Sandra Loosemore Sept. 15, 2018, 1:47 a.m.
The attached patch fixes almost 400 failures in gdb.base/align.exp and 
related tests due to a missing definition for the type_align hook for 
nios2.  I swiped the definition of the hook from the arc backend which 
has similar conventions: the alignment of byte/halfword types matches 
their size, but all types 4 bytes or larger are aligned on a 4-byte 
boundary.

OK to commit?

-Sandra

Comments

Tom Tromey Sept. 15, 2018, 2:57 a.m. | #1
>>>>> "Sandra" == Sandra Loosemore <sandra@codesourcery.com> writes:


Sandra> The attached patch fixes almost 400 failures in gdb.base/align.exp and
Sandra> related tests due to a missing definition for the type_align hook for
Sandra> nios2.  I swiped the definition of the hook from the arc backend which
Sandra> has similar conventions: the alignment of byte/halfword types matches
Sandra> their size, but all types 4 bytes or larger are aligned on a 4-byte
Sandra> boundary.

Sandra> OK to commit?

Thank you for the patch.  This is ok.

Tom

Patch

commit e05f7a65e4cefcd706b79b07b3941a9c6130c01a
Author: Sandra Loosemore <sandra@codesourcery.com>
Date:   Fri Sep 14 18:33:56 2018 -0700

    Provide type_align gdbarch function for nios2.
    
    2018-09-14  Sandra Loosemore  <sandra@codesourcery.com>
    
    	gdb/
    	* nios2-tdep.c (nios2_type_align): New.
    	(nios2_gdb_arch_init): Install type_align hook.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4e667b7..6fe0526 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-09-14  Sandra Loosemore  <sandra@codesourcery.com>
+
+	* nios2-tdep.c (nios2_type_align): New.
+	(nios2_gdb_arch_init): Install type_align hook.
+
 2018-09-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* eval.c (fake_method::fake_method): Call xzalloc directly for a
diff --git a/gdb/nios2-tdep.c b/gdb/nios2-tdep.c
index c7d5b9f..eb5285a 100644
--- a/gdb/nios2-tdep.c
+++ b/gdb/nios2-tdep.c
@@ -2230,6 +2230,15 @@  nios2_get_longjmp_target (struct frame_info *frame, CORE_ADDR *pc)
   return 1;
 }
 
+/* Implement the type_align gdbarch function.  */
+
+static ULONGEST
+nios2_type_align (struct gdbarch *gdbarch, struct type *type)
+{
+  type = check_typedef (type);
+  return std::min<ULONGEST> (4, TYPE_LENGTH (type));
+}
+
 /* Initialize the Nios II gdbarch.  */
 
 static struct gdbarch *
@@ -2293,6 +2302,8 @@  nios2_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   set_gdbarch_float_bit (gdbarch, 32);
   set_gdbarch_double_bit (gdbarch, 64);
 
+  set_gdbarch_type_align (gdbarch, nios2_type_align);
+
   set_gdbarch_float_format (gdbarch, floatformats_ieee_single);
   set_gdbarch_double_format (gdbarch, floatformats_ieee_double);