[v2,1/2] LD: Avoid a division by zero page size with SEGMENT_START handling

Message ID alpine.LFD.2.21.1809132347510.16413@eddie.linux-mips.org
State New
Headers show
Series
  • LD: SEGMENT_START expression handling fixes
Related show

Commit Message

Maciej W. Rozycki Sept. 13, 2018, 11:41 p.m.
Avoid a division by zero and thus a linker crash in SEGMENT_START script 
builtin function handling, by not checking the value supplied with a 
`-T' command-line override against the maximum page size if that has not 
been set.

	ld/
	* ldexp.c (fold_binary): Check that `config.maxpagesize' is 
	non-zero before using it as a divisor.
---
New in v2.
---
 ld/ldexp.c |    1 +
 1 file changed, 1 insertion(+)

binutils-ld-segment-start-maxpagesize.diff

Patch

Index: src/ld/ldexp.c
===================================================================
--- src.orig/ld/ldexp.c
+++ src/ld/ldexp.c
@@ -545,6 +545,7 @@  fold_binary (etree_type *tree)
 	  {
 	    if (!seg->used
 		&& config.magic_demand_paged
+		&& config.maxpagesize != 0
 		&& (seg->value % config.maxpagesize) != 0)
 	      einfo (_("%P: warning: address of `%s' "
 		       "isn't multiple of maximum page size\n"),