[Ada] Do not perform useless work in Check_No_Parts_Violations

Message ID 20210616084355.GA95063@adacore.com
State New
Headers show
Series
  • [Ada] Do not perform useless work in Check_No_Parts_Violations
Related show

Commit Message

Pierre-Marie de Rodat June 16, 2021, 8:43 a.m.
There is no need to walk the hierarchy rooted at a type that does not
come from source only to drop the result on the floor.  No functional
changes.

Tested on x86_64-pc-linux-gnu, committed on trunk

gcc/ada/

	* freeze.adb (Check_No_Parts_Violations): Return earlier if the
	type is elementary or does not come from source.

Patch

diff --git a/gcc/ada/freeze.adb b/gcc/ada/freeze.adb
--- a/gcc/ada/freeze.adb
+++ b/gcc/ada/freeze.adb
@@ -2584,27 +2584,30 @@  package body Freeze is
 
          --  Local declarations
 
-         Types_With_Aspect : Elist_Id :=
-           Get_Types_With_Aspect_In_Hierarchy (Typ);
-
-         Aspect_Value     : Entity_Id;
-         Curr_Value       : Entity_Id;
-         Curr_Typ_Elmt    : Elmt_Id;
-         Curr_Body_Elmt   : Elmt_Id;
-         Curr_Formal_Elmt : Elmt_Id;
-         Gen_Bodies       : Elist_Id;
-         Gen_Formals      : Elist_Id;
-         Scop             : Entity_Id;
+         Aspect_Value      : Entity_Id;
+         Curr_Value        : Entity_Id;
+         Curr_Typ_Elmt     : Elmt_Id;
+         Curr_Body_Elmt    : Elmt_Id;
+         Curr_Formal_Elmt  : Elmt_Id;
+         Gen_Bodies        : Elist_Id;
+         Gen_Formals       : Elist_Id;
+         Scop              : Entity_Id;
+         Types_With_Aspect : Elist_Id;
 
       --  Start of processing for Check_No_Parts_Violations
 
       begin
-         --  There are no types with No_Parts specified, so there
-         --  is nothing to check.
+         --  Nothing to check if the type is elementary or artificial
 
-         if Is_Empty_Elmt_List (Types_With_Aspect)
-           or else not Comes_From_Source (Typ)
-         then
+         if Is_Elementary_Type (Typ) or else not Comes_From_Source (Typ) then
+            return;
+         end if;
+
+         Types_With_Aspect := Get_Types_With_Aspect_In_Hierarchy (Typ);
+
+         --  Nothing to check if there are no types with No_Parts specified
+
+         if Is_Empty_Elmt_List (Types_With_Aspect) then
             return;
          end if;