Fix effective target for check-builtin-vec_rlnm-runnable.c test

Message ID 2687d1171bbebbd51e2e2285e835f6ef352d7a01.camel@us.ibm.com
State New
Headers show
Series
  • Fix effective target for check-builtin-vec_rlnm-runnable.c test
Related show

Commit Message

H.J. Lu via Gcc-patches June 11, 2021, 9:19 p.m.
GCC maintainers:

The gcc test suite compiles and attempts to run the check-builtin-
vec_rlnm-runnable.c test on Power 8 platforms.  The test should only be
run on Power 9 and newer platforms.  The attached patch fixes the
target for the executable test so it only runs on Power 9 and newer
platforms.

The patch was tested on powerpc64-linux instead (Power 8 BE).  The test
harness reports 1 unsupported test.

The patch was also tested on:

    powerpc64le-linux instead (Power 9 LE)
    powerpc64le-linux instead (Power 10 LE)

The test harness reports 3 expected passes and no failures.

Please let me know if the patch looks OK for mainline.  Thanks.

                Carl 

-----------------------------------------


The effective target for a Power 9 runnable test should be
p9vector_hw.

2021-06-11  Carl Love  <cel@us.ibm.com>

gcc/testsuite/ChangeLog

	* gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c (dg-require-effective-target):
	Change target to p9vector_hw.
---
 .../gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Segher Boessenkool June 11, 2021, 10:23 p.m. | #1
Hi!

On Fri, Jun 11, 2021 at 02:19:40PM -0700, Carl Love wrote:
> The gcc test suite compiles and attempts to run the check-builtin-

> vec_rlnm-runnable.c test on Power 8 platforms.  The test should only be

> run on Power 9 and newer platforms.  The attached patch fixes the

> target for the executable test so it only runs on Power 9 and newer

> platforms.


> 	* gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c (dg-require-effective-target):

> 	Change target to p9vector_hw.


You would put the ( on a new line, lik:
	* gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c
	(dg-require-effective-target): Change target to p9vector_hw.

Okay for trunk like that.  Thanks!


Segher

Patch

diff --git a/gcc/testsuite/gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c b/gcc/testsuite/gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c
index cd67b06afbe..55935eaafd2 100644
--- a/gcc/testsuite/gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c
+++ b/gcc/testsuite/gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c
@@ -1,5 +1,5 @@ 
 /* { dg-do run } */
-/* { dg-require-effective-target powerpc_p9vector_ok } */
+/* { dg-require-effective-target p9vector_hw } */
 /* { dg-options "-O2 -mdejagnu-cpu=power9 -save-temps" } */
 
 /* Verify the vec_rlm and vec_rlmi builtins works correctly.  */