[pushed] gdb/testsuite: gdb.base/continue-all-already-running.exp: add fail if can't run to main

Message ID 20210607165358.865369-1-simon.marchi@polymtl.ca
State New
Headers show
Series
  • [pushed] gdb/testsuite: gdb.base/continue-all-already-running.exp: add fail if can't run to main
Related show

Commit Message

Metzger, Markus T via Gdb-patches June 7, 2021, 4:53 p.m.
While doing some changes, I managed to break this test in a way that
running to main didn't work.  However, it didn't produce any FAIL.  I
noticed because I diff'ed the results and saw some PASSes unexpectedly
disappear, but that's a bit fragile.  Add a fail in case this test fails
to run to main.  Ideally, I think that runto_main should by default
produce a FAIL when it fails (the opposite of the existing logic), but
that's a project of its own, so just fix this test for the moment.

gdb/testsuite/ChangeLog:

	* gdb.base/continue-all-already-running.exp: Call fail if can't
	run to main.

Change-Id: I84b816a126c92ac579ed5ebbe39b017bd5cb7096
---
 gdb/testsuite/ChangeLog                                 | 5 +++++
 gdb/testsuite/gdb.base/continue-all-already-running.exp | 1 +
 2 files changed, 6 insertions(+)

-- 
2.31.1

Patch

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index fd78401774b0..45040960d0f0 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@ 
+2021-06-07  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* gdb.base/continue-all-already-running.exp: Call fail if can't
+	run to main.
+
 2021-06-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	PR gdb/27847
diff --git a/gdb/testsuite/gdb.base/continue-all-already-running.exp b/gdb/testsuite/gdb.base/continue-all-already-running.exp
index 23cd9920bc73..de84897c7667 100644
--- a/gdb/testsuite/gdb.base/continue-all-already-running.exp
+++ b/gdb/testsuite/gdb.base/continue-all-already-running.exp
@@ -26,6 +26,7 @@  save_vars { GDBFLAGS } {
 }
 
 if ![runto_main] {
+    fail "can't run to main"
     return
 }