[pushed] c++: ICE casting class to vector [PR100517]

Message ID 20210511142031.331770-1-jason@redhat.com
State New
Headers show
Series
  • [pushed] c++: ICE casting class to vector [PR100517]
Related show

Commit Message

H.J. Lu via Gcc-patches May 11, 2021, 2:20 p.m.
My recent change to reject calling rvalue() with an argument of class type
crashes on this testcase, where we use rvalue() on what we expect to be an
argument of integer or vector type.  Fixed by checking first.

Tested x86_64-pc-linux-gnu, applying to trunk.

gcc/cp/ChangeLog:

	PR c++/100517
	* typeck.c (build_reinterpret_cast_1): Check intype on
	cast to vector.

gcc/testsuite/ChangeLog:

	PR c++/100517
	* g++.dg/ext/vector41.C: New test.
---
 gcc/cp/typeck.c                     |  2 +-
 gcc/testsuite/g++.dg/ext/vector41.C | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 gcc/testsuite/g++.dg/ext/vector41.C


base-commit: 2301a394607b88f8996efe864350c5f841000f76
-- 
2.27.0

Patch

diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index 9002dd14fae..703ddd3cc7a 100644
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -8114,7 +8114,7 @@  build_reinterpret_cast_1 (location_t loc, tree type, tree expr,
 		    "pointer-to-object is conditionally-supported");
       return build_nop_reinterpret (type, expr);
     }
-  else if (gnu_vector_type_p (type))
+  else if (gnu_vector_type_p (type) && scalarish_type_p (intype))
     return convert_to_vector (type, rvalue (expr));
   else if (gnu_vector_type_p (intype)
 	   && INTEGRAL_OR_ENUMERATION_TYPE_P (type))
diff --git a/gcc/testsuite/g++.dg/ext/vector41.C b/gcc/testsuite/g++.dg/ext/vector41.C
new file mode 100644
index 00000000000..bfc3bb6db4b
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/vector41.C
@@ -0,0 +1,12 @@ 
+// PR c++/100517
+// { dg-options "" }
+
+typedef int __v2si __attribute__ ((__vector_size__ (8)));
+
+struct S { };
+
+void
+f (S s)
+{
+  (void) reinterpret_cast<__v2si> (s); // { dg-error "" }
+}