[Ada] Remove hardcoded pragma Warnings from the formal vectors library

Message ID 20210506075812.GA125623@adacore.com
State New
Headers show
Series
  • [Ada] Remove hardcoded pragma Warnings from the formal vectors library
Related show

Commit Message

Pierre-Marie de Rodat May 6, 2021, 7:58 a.m.
Pragma Warnings in the generic formal vectors library was only
suppressing a message in one specific instantiation within one specific
GNATprove test.  This pragma was referring to "type T defined at line
4", which is exactly the type declared in that test; the suppression
didn't work for any other instantiations.

Tested on x86_64-pc-linux-gnu, committed on trunk

gcc/ada/

	* libgnat/a-cofove.adb (Insert_Space): Remove hardcoded pragma
	Warnings.

Patch

diff --git a/gcc/ada/libgnat/a-cofove.adb b/gcc/ada/libgnat/a-cofove.adb
--- a/gcc/ada/libgnat/a-cofove.adb
+++ b/gcc/ada/libgnat/a-cofove.adb
@@ -868,11 +868,7 @@  is
             --  less than 0, so it is safe to compute the following sum without
             --  fear of overflow.
 
-            pragma Warnings
-              (Off, "value not in range of type ""T"" defined at line 4");
             Index := No_Index + Index_Type'Base (Count_Type'Last);
-            pragma Warnings
-              (On, "value not in range of type ""T"" defined at line 4");
 
             if Index <= Index_Type'Last then