[03/10] Add stamp files for generated files in sim/ppc

Message ID 20210408203312.2938165-4-tom@tromey.com
State New
Headers show
Series
  • sim build improvements
Related show

Commit Message

Tom Tromey April 8, 2021, 8:33 p.m.
This changes the sim/ppc Makefile to use the stamp file idiom for a
couple of generated files, avoiding extra rebuilds.

sim/ppc/ChangeLog
2021-04-08  Tom Tromey  <tom@tromey.com>

	* Makefile.in (stamp-vals, stamp-map): New targets.
	(targ-vals.h, targ-map.c): Update.
	(clean): Remove files.
---
 sim/ppc/ChangeLog   | 6 ++++++
 sim/ppc/Makefile.in | 9 +++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

-- 
2.26.2

Comments

Mike Frysinger via Gdb-patches April 9, 2021, 12:25 a.m. | #1
On 08 Apr 2021 14:33, Tom Tromey wrote:
> This changes the sim/ppc Makefile to use the stamp file idiom for a

> couple of generated files, avoiding extra rebuilds.


lgtm, thanks
-mike

Patch

diff --git a/sim/ppc/Makefile.in b/sim/ppc/Makefile.in
index d9d01985404..7686937f421 100644
--- a/sim/ppc/Makefile.in
+++ b/sim/ppc/Makefile.in
@@ -635,15 +635,19 @@  targ-vals.def: $(srcdir)/../common/nltvals.def
 	cat $(srcdir)/../common/nltvals.def > tmp-vals.def
 	$(SHELL) $(srcdir)/../../move-if-change tmp-vals.def targ-vals.def
 
-targ-vals.h: Makefile gentmap $(srcdir)/../../move-if-change
+targ-vals.h: stamp-vals ; @true
+stamp-vals: Makefile gentmap $(srcdir)/../../move-if-change
 	rm -f tmp-vals.h
 	./gentmap -h > tmp-vals.h
 	$(SHELL) $(srcdir)/../../move-if-change tmp-vals.h targ-vals.h
+	@echo stamp > stamp-vals
 
-targ-map.c: Makefile gentmap $(srcdir)/../../move-if-change
+targ-map.c: stamp-map; @true
+stamp-map: Makefile gentmap $(srcdir)/../../move-if-change
 	rm -f tmp-map.c
 	./gentmap -c > tmp-map.c
 	$(SHELL) $(srcdir)/../../move-if-change tmp-map.c targ-map.c
+	@echo stamp > stamp-map
 
 callback.o: $(srcdir)/../common/callback.c $(TARG_VALS_H) $(CONFIG_H)
 	$(CC) -c $(STD_CFLAGS) -DHAVE_CONFIG_H $(srcdir)/../common/callback.c
@@ -871,6 +875,7 @@  TAGS: $(BUILT_SRC)
 
 clean mostlyclean:
 	rm -f tmp-* *.[oasi] core psim$(EXEEXT) run$(EXEEXT) igen dgen $(BUILT_SRC_WO_CONFIG) gentmap
+	rm -f stamp-vals targ-vals.h stamp-map targ-map.c
 
 distclean realclean: clean
 	rm -f TAGS Makefile config.cache config.status config.h defines.h stamp-h config.log