x86: Remove unused variables for raw cache sizes

Message ID 87eejjw0gw.fsf@oldenburg2.str.redhat.com
State New
Headers show
Series
  • x86: Remove unused variables for raw cache sizes
Related show

Commit Message

H.J. Lu via Libc-alpha Dec. 21, 2020, 5:08 p.m.
---
 sysdeps/x86/cacheinfo.h | 12 ------------
 1 file changed, 12 deletions(-)


-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill

Comments

H.J. Lu via Libc-alpha Feb. 22, 2021, 2:53 p.m. | #1
On Mon, Dec 21, 2020 at 9:09 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>

> ---

>  sysdeps/x86/cacheinfo.h | 12 ------------

>  1 file changed, 12 deletions(-)

>

> diff --git a/sysdeps/x86/cacheinfo.h b/sysdeps/x86/cacheinfo.h

> index 0aec0e2875..4c710f3c6c 100644

> --- a/sysdeps/x86/cacheinfo.h

> +++ b/sysdeps/x86/cacheinfo.h

> @@ -23,18 +23,10 @@

>     L1 size, rounded to multiple of 256 bytes.  */

>  long int __x86_data_cache_size_half attribute_hidden = 32 * 1024 / 2;

>  long int __x86_data_cache_size attribute_hidden = 32 * 1024;

> -/* Similar to __x86_data_cache_size_half, but not rounded.  */

> -long int __x86_raw_data_cache_size_half attribute_hidden = 32 * 1024 / 2;

> -/* Similar to __x86_data_cache_size, but not rounded.  */

> -long int __x86_raw_data_cache_size attribute_hidden = 32 * 1024;

>  /* Shared cache size for use in memory and string routines, typically

>     L2 or L3 size, rounded to multiple of 256 bytes.  */

>  long int __x86_shared_cache_size_half attribute_hidden = 1024 * 1024 / 2;

>  long int __x86_shared_cache_size attribute_hidden = 1024 * 1024;

> -/* Similar to __x86_shared_cache_size_half, but not rounded.  */

> -long int __x86_raw_shared_cache_size_half attribute_hidden = 1024 * 1024 / 2;

> -/* Similar to __x86_shared_cache_size, but not rounded.  */

> -long int __x86_raw_shared_cache_size attribute_hidden = 1024 * 1024;

>

>  /* Threshold to use non temporal store.  */

>  long int __x86_shared_non_temporal_threshold attribute_hidden;

> @@ -360,8 +352,6 @@ init_cacheinfo (void)

>

>    if (data > 0)

>      {

> -      __x86_raw_data_cache_size_half = data / 2;

> -      __x86_raw_data_cache_size = data;

>        /* Round data cache size to multiple of 256 bytes.  */

>        data = data & ~255L;

>        __x86_data_cache_size_half = data / 2;

> @@ -374,8 +364,6 @@ init_cacheinfo (void)

>

>    if (shared > 0)

>      {

> -      __x86_raw_shared_cache_size_half = shared / 2;

> -      __x86_raw_shared_cache_size = shared;

>        /* Round shared cache size to multiple of 256 bytes.  */

>        shared = shared & ~255L;

>        __x86_shared_cache_size_half = shared / 2;

>


LGTM.

Thanks.

-- 
H.J.

Patch

diff --git a/sysdeps/x86/cacheinfo.h b/sysdeps/x86/cacheinfo.h
index 0aec0e2875..4c710f3c6c 100644
--- a/sysdeps/x86/cacheinfo.h
+++ b/sysdeps/x86/cacheinfo.h
@@ -23,18 +23,10 @@ 
    L1 size, rounded to multiple of 256 bytes.  */
 long int __x86_data_cache_size_half attribute_hidden = 32 * 1024 / 2;
 long int __x86_data_cache_size attribute_hidden = 32 * 1024;
-/* Similar to __x86_data_cache_size_half, but not rounded.  */
-long int __x86_raw_data_cache_size_half attribute_hidden = 32 * 1024 / 2;
-/* Similar to __x86_data_cache_size, but not rounded.  */
-long int __x86_raw_data_cache_size attribute_hidden = 32 * 1024;
 /* Shared cache size for use in memory and string routines, typically
    L2 or L3 size, rounded to multiple of 256 bytes.  */
 long int __x86_shared_cache_size_half attribute_hidden = 1024 * 1024 / 2;
 long int __x86_shared_cache_size attribute_hidden = 1024 * 1024;
-/* Similar to __x86_shared_cache_size_half, but not rounded.  */
-long int __x86_raw_shared_cache_size_half attribute_hidden = 1024 * 1024 / 2;
-/* Similar to __x86_shared_cache_size, but not rounded.  */
-long int __x86_raw_shared_cache_size attribute_hidden = 1024 * 1024;
 
 /* Threshold to use non temporal store.  */
 long int __x86_shared_non_temporal_threshold attribute_hidden;
@@ -360,8 +352,6 @@  init_cacheinfo (void)
 
   if (data > 0)
     {
-      __x86_raw_data_cache_size_half = data / 2;
-      __x86_raw_data_cache_size = data;
       /* Round data cache size to multiple of 256 bytes.  */
       data = data & ~255L;
       __x86_data_cache_size_half = data / 2;
@@ -374,8 +364,6 @@  init_cacheinfo (void)
 
   if (shared > 0)
     {
-      __x86_raw_shared_cache_size_half = shared / 2;
-      __x86_raw_shared_cache_size = shared;
       /* Round shared cache size to multiple of 256 bytes.  */
       shared = shared & ~255L;
       __x86_shared_cache_size_half = shared / 2;