[configure] Added "nfp" to the build for binutils.

Message ID 20180430182141.28935-1-francois.theron@netronome.com
State New
Headers show
Series
  • [configure] Added "nfp" to the build for binutils.
Related show

Commit Message

Francois H. Theron April 30, 2018, 6:21 p.m.
* Excludes: ld gas gdb gprof sim
* For https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=fe944acf8f858cfe6bcfd00670a88847a464717c

Signed-off-by: Francois H. Theron <francois.theron@netronome.com>

---
 ChangeLog    | 6 ++++++
 configure    | 4 ++++
 configure.ac | 4 ++++
 3 files changed, 14 insertions(+)

Comments

Joel Brobecker April 30, 2018, 7:52 p.m. | #1
> +2018-04-30  Francois H. Theron <francois.theron@netronome.com>

> +

> +	* config.sub: Added "nfp" to basic_machine list.

> +	* configure.ac: Added "nfp" target.

> +	* configure: Regenerate.


I am not a maintainer, but I noticed that config.sub is not being
modified by this commit -- a small discrepancy between the patch
and the propose ChangeLog entry.

>  2018-02-13  Maciej W. Rozycki  <macro@mips.com>

>  

>  	* configure.ac <wasm32-*-*> (noconfigdirs): Add `ld'.

> diff --git a/configure b/configure

> index 0601395512..69c99e99cc 100755

> --- a/configure

> +++ b/configure

> @@ -3777,6 +3777,10 @@ case "${target}" in

>    mt-*-*)

>      noconfigdirs="$noconfigdirs sim"

>      ;;

> +  nfp-*-*)

> +    noconfigdirs="$noconfigdirs ld gas gdb gprof sim"

> +    noconfigdirs="$noconfigdirs $target_libraries"

> +    ;;

>    powerpc-*-aix*)

>      # copied from rs6000-*-* entry

>      noconfigdirs="$noconfigdirs gprof"

> diff --git a/configure.ac b/configure.ac

> index c343333652..a1edc369a2 100644

> --- a/configure.ac

> +++ b/configure.ac

> @@ -1108,6 +1108,10 @@ case "${target}" in

>    mt-*-*)

>      noconfigdirs="$noconfigdirs sim"

>      ;;

> +  nfp-*-*)

> +    noconfigdirs="$noconfigdirs ld gas gdb gprof sim"

> +    noconfigdirs="$noconfigdirs $target_libraries"

> +    ;;

>    powerpc-*-aix*)

>      # copied from rs6000-*-* entry

>      noconfigdirs="$noconfigdirs gprof"



-- 
Joel
Francois H. Theron May 1, 2018, 11:41 a.m. | #2
On 30 April 2018 at 21:52, Joel Brobecker <brobecker@adacore.com> wrote:
>> +2018-04-30  Francois H. Theron <francois.theron@netronome.com>

>> +

>> +     * config.sub: Added "nfp" to basic_machine list.

>> +     * configure.ac: Added "nfp" target.

>> +     * configure: Regenerate.

>

> I am not a maintainer, but I noticed that config.sub is not being

> modified by this commit -- a small discrepancy between the patch

> and the propose ChangeLog entry.


That was a mistake when splitting the diff to have config.sub
separate. For the record, it has been accepted here after the
maintainer graciously added a ChangeLog entry and a test-case:
http://git.savannah.gnu.org/cgit/config.git/commit/?id=d23f148145b62e7dea44581097f60358118f87f8

For this patch, I can resubmit a new patch with the config.sub line
removed from ChangeLog or ask that the maintainer removes this one
line when committing. Or if I misunderstood the contribution process I
can add the now accepted config.sub to the patch and not change the
ChangeLog.

Francois
Nick Clifton May 1, 2018, 3:28 p.m. | #3
Hi Francois,

> 2018-05-01  Francois H. Theron  <francois.theron@netronome.com>

> 

> 	* configure.ac: Added "nfp" target.

> 	* configure: Regenerate.


I have applied this change patch to both the gcc and binutils mainline sources.

Cheers
  Nick

Patch

diff --git a/ChangeLog b/ChangeLog
index 03e1852114..edb69ed8b5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@ 
+2018-04-30  Francois H. Theron <francois.theron@netronome.com>
+
+	* config.sub: Added "nfp" to basic_machine list.
+	* configure.ac: Added "nfp" target.
+	* configure: Regenerate.
+
 2018-02-13  Maciej W. Rozycki  <macro@mips.com>
 
 	* configure.ac <wasm32-*-*> (noconfigdirs): Add `ld'.
diff --git a/configure b/configure
index 0601395512..69c99e99cc 100755
--- a/configure
+++ b/configure
@@ -3777,6 +3777,10 @@  case "${target}" in
   mt-*-*)
     noconfigdirs="$noconfigdirs sim"
     ;;
+  nfp-*-*)
+    noconfigdirs="$noconfigdirs ld gas gdb gprof sim"
+    noconfigdirs="$noconfigdirs $target_libraries"
+    ;;
   powerpc-*-aix*)
     # copied from rs6000-*-* entry
     noconfigdirs="$noconfigdirs gprof"
diff --git a/configure.ac b/configure.ac
index c343333652..a1edc369a2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1108,6 +1108,10 @@  case "${target}" in
   mt-*-*)
     noconfigdirs="$noconfigdirs sim"
     ;;
+  nfp-*-*)
+    noconfigdirs="$noconfigdirs ld gas gdb gprof sim"
+    noconfigdirs="$noconfigdirs $target_libraries"
+    ;;
   powerpc-*-aix*)
     # copied from rs6000-*-* entry
     noconfigdirs="$noconfigdirs gprof"