testsuite: gimplefe-44 requires exceptions

Message ID 85ba423e-6777-4af9-52d8-f139ce007041@codesourcery.com
State New
Headers show
Series
  • testsuite: gimplefe-44 requires exceptions
Related show

Commit Message

Andrew Stubbs Sept. 10, 2020, 2:03 p.m.
This patch prevents an ICE (segmentation fault) the occurs for amdgcn 
because the test is trying to use -fexceptions which is unsupported on 
the target.

Arguably it should fail more gracefully, but either way the test is 
inappropriate.

OK to commit?

Andrew

Comments

H.J. Lu via Gcc-patches Sept. 10, 2020, 2:21 p.m. | #1
On Thu, Sep 10, 2020 at 4:04 PM Andrew Stubbs <ams@codesourcery.com> wrote:
>

> This patch prevents an ICE (segmentation fault) the occurs for amdgcn

> because the test is trying to use -fexceptions which is unsupported on

> the target.

>

> Arguably it should fail more gracefully, but either way the test is

> inappropriate.

>

> OK to commit?


Sure.

Richard.

> Andrew
Andrew Stubbs Sept. 11, 2020, 2:09 p.m. | #2
This is now committed and backported to GCC 10.

Andrew

On 10/09/2020 15:03, Andrew Stubbs wrote:
> This patch prevents an ICE (segmentation fault) the occurs for amdgcn 

> because the test is trying to use -fexceptions which is unsupported on 

> the target.

> 

> Arguably it should fail more gracefully, but either way the test is 

> inappropriate.

> 

> OK to commit?

> 

> Andrew

Patch

testsuite: gimplefe-44 requires exceptions

This avoids an ICE on amdgcn.

gcc/testsuite/ChangeLog:

	* gcc.dg/gimplefe-44.c: Require exceptions.

diff --git a/gcc/testsuite/gcc.dg/gimplefe-44.c b/gcc/testsuite/gcc.dg/gimplefe-44.c
index a9a92b1701e..a1e32ad6927 100644
--- a/gcc/testsuite/gcc.dg/gimplefe-44.c
+++ b/gcc/testsuite/gcc.dg/gimplefe-44.c
@@ -1,4 +1,5 @@ 
 /* { dg-do compile } */
+/* { dg-require-effective-target exceptions } */
 /* { dg-options "-fexceptions -fgimple -fdump-tree-eh-eh" } */
 
 void __GIMPLE foo()