[committed] MIPS/GAS: Remove stale `prev_reloc_op_frag' variable

Message ID alpine.LFD.2.21.2007210123350.234068@eddie.linux-mips.org
State New
Headers show
Series
  • [committed] MIPS/GAS: Remove stale `prev_reloc_op_frag' variable
Related show

Commit Message

Maciej W. Rozycki July 21, 2020, 1:01 a.m.
Ever since commit 4d7206a284ee ("Rework MIPS macro relaxation, fix string
merging bug"), <https://sourceware.org/ml/binutils/2004-01/msg00248.html>,
`prev_reloc_op_frag' has only been set and never used.  Remove it then.

	gas/
	* config/tc-mips.c (prev_reloc_op_frag): Remove variable.
	(my_getSmallExpression): Adjust accordingly.
---
No regressions across my usual MIPS targets; committed.
---
 gas/config/tc-mips.c |   13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

binutils-mips-gas-prev_reloc_op_frag.diff

Patch

Index: binutils/gas/config/tc-mips.c
===================================================================
--- binutils.orig/gas/config/tc-mips.c
+++ binutils/gas/config/tc-mips.c
@@ -889,11 +889,6 @@  struct mips_hi_fixup
 
 static struct mips_hi_fixup *mips_hi_fixup_list;
 
-/* The frag containing the last explicit relocation operator.
-   Null if explicit relocations have not been used.  */
-
-static fragS *prev_reloc_op_frag;
-
 /* Map mips16 register numbers to normal MIPS register numbers.  */
 
 static const unsigned int mips16_to_32_reg_map[] =
@@ -14720,12 +14715,8 @@  my_getSmallExpression (expressionS *ep,
 
   expr_end = str;
 
-  if (reloc_index != 0)
-    {
-      prev_reloc_op_frag = frag_now;
-      for (i = 0; i < reloc_index; i++)
-	reloc[i] = reversed_reloc[reloc_index - 1 - i];
-    }
+  for (i = 0; i < reloc_index; i++)
+    reloc[i] = reversed_reloc[reloc_index - 1 - i];
 
   return reloc_index;
 }