libgo patch committed: Don't check for a stale runtime

Message ID
State New
Headers show
  • libgo patch committed: Don't check for a stale runtime
Related show

Commit Message

Ian Lance Taylor March 26, 2018, 7:29 p.m.
The runtime tests, as expected by the gotools testsuite, check whether
the runtime package is stale.  The gccgo runtime package can never be
stale, and checking for staleness can cause confusion if it winds up
checking the gc package instead.  Skip the test for gccgo.
Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.  Committed
to mainline.



Index: gcc/go/gofrontend/MERGE
--- gcc/go/gofrontend/MERGE	(revision 258725)
+++ gcc/go/gofrontend/MERGE	(working copy)
@@ -1,4 +1,4 @@ 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: libgo/go/runtime/crash_test.go
--- libgo/go/runtime/crash_test.go	(revision 258725)
+++ libgo/go/runtime/crash_test.go	(working copy)
@@ -150,6 +150,9 @@  var (
 func checkStaleRuntime(t *testing.T) {
 	staleRuntimeOnce.Do(func() {
+		if runtime.Compiler == "gccgo" {
+			return
+		}
 		// 'go run' uses the installed copy of runtime.a, which may be out of date.
 		out, err := testenv.CleanCmdEnv(exec.Command(testenv.GoToolPath(t), "list", "-gcflags=all="+os.Getenv("GO_GCFLAGS"), "-f", "{{.Stale}}", "runtime")).CombinedOutput()
 		if err != nil {