[v2,1/2] btrace: fix output of "set record btrace"

Message ID 1520247555-4643-1-git-send-email-markus.t.metzger@intel.com
State New
Headers show
Series
  • [v2,1/2] btrace: fix output of "set record btrace"
Related show

Commit Message

Metzger, Markus T March 5, 2018, 10:59 a.m.
Instead of giving a message that "set record btrace" needs a sub-command,
GDB crashed.  Fix it.  A regression test comes with the next patch.

2018-03-05  Markus Metzger  <markus.t.metzger@intel.com>

gdb/
	* record-btrace.c (cmd_set_record_btrace): Print sub-commands.
---
 gdb/record-btrace.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
1.8.3.1

Comments

Alan Hayward March 5, 2018, 4:35 p.m. | #1
> On 5 Mar 2018, at 10:59, Markus Metzger <markus.t.metzger@intel.com> wrote:

> 

> Instead of giving a message that "set record btrace" needs a sub-command,

> GDB crashed.  Fix it.  A regression test comes with the next patch.

> 

> 2018-03-05  Markus Metzger  <markus.t.metzger@intel.com>

> 

> gdb/

> 	* record-btrace.c (cmd_set_record_btrace): Print sub-commands.

> ---

> gdb/record-btrace.c | 5 ++++-

> 1 file changed, 4 insertions(+), 1 deletion(-)

> 

> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c

> index 48eda54..905f0c4 100644

> --- a/gdb/record-btrace.c

> +++ b/gdb/record-btrace.c

> @@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int from_tty)

> static void

> cmd_set_record_btrace (const char *args, int from_tty)

> {

> -  cmd_show_list (set_record_btrace_cmdlist, from_tty, "");

> +  printf_unfiltered (_("\"set record btrace\" must be followed "

> +		       "by an apporpriate subcommand.\n"));


appropriate not apporpriate.

Otherwise, looks ok to me, and works when I tested it.

> +  help_list (set_record_btrace_cmdlist, "set record btrace ",

> +	     all_commands, gdb_stdout);

> }

> 

> /* The "show record btrace" command.  */

> -- 

> 1.8.3.1

>
Metzger, Markus T March 5, 2018, 4:55 p.m. | #2
Hello Alan,

Thanks for your review.

> > Instead of giving a message that "set record btrace" needs a

> > sub-command, GDB crashed.  Fix it.  A regression test comes with the next

> patch.

> >

> > 2018-03-05  Markus Metzger  <markus.t.metzger@intel.com>

> >

> > gdb/

> > 	* record-btrace.c (cmd_set_record_btrace): Print sub-commands.

> > ---

> > gdb/record-btrace.c | 5 ++++-

> > 1 file changed, 4 insertions(+), 1 deletion(-)

> >

> > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index

> > 48eda54..905f0c4 100644

> > --- a/gdb/record-btrace.c

> > +++ b/gdb/record-btrace.c

> > @@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int

> > from_tty) static void cmd_set_record_btrace (const char *args, int

> > from_tty) {

> > -  cmd_show_list (set_record_btrace_cmdlist, from_tty, "");

> > +  printf_unfiltered (_("\"set record btrace\" must be followed "

> > +		       "by an apporpriate subcommand.\n"));

> 

> appropriate not apporpriate.


Thanks.  I'm adding another patch to the series to fix that same typo in the
"set record" command from where I took the message.  See below.

Looks like this text is not used in any test (grep did not find anything),
except for the new gdb.btrace/cpu.exp that 2/2 of this series adds.

Regards,
Markus.

---

commit 755376c12a2fa53d8304ff68265a09b8a332e965
Author: Markus Metzger <markus.t.metzger@intel.com>
Date:   Mon Mar 5 17:44:57 2018 +0100

    record: fix typo in "set record" output
    
    Alan Hayward pointed out a typo in the output of "set record btrace" that
    I took from "set record".  Fix the original.
    
    Signed-off-by: Markus Metzger  <markus.t.metzger@intel.com>

    
    gdb/
        * record.c (set_record_command): Fix typo in message.

diff --git a/gdb/record.c b/gdb/record.c
index cd83b99..aec2be3 100644
--- a/gdb/record.c
+++ b/gdb/record.c
@@ -320,7 +320,7 @@ static void
 set_record_command (const char *args, int from_tty)
 {
   printf_unfiltered (_("\"set record\" must be followed "
-                      "by an apporpriate subcommand.\n"));
+                      "by an appropriate subcommand.\n"));
   help_list (set_record_cmdlist, "set record ", all_commands, gdb_stdout);
 }

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Alan Hayward March 6, 2018, 9:34 a.m. | #3
> On 5 Mar 2018, at 16:55, Metzger, Markus T <markus.t.metzger@intel.com> wrote:

> 

> Hello Alan,

> 

> Thanks for your review.

> 

>>> Instead of giving a message that "set record btrace" needs a

>>> sub-command, GDB crashed.  Fix it.  A regression test comes with the next

>> patch.

>>> 

>>> 2018-03-05  Markus Metzger  <markus.t.metzger@intel.com>

>>> 

>>> gdb/

>>> 	* record-btrace.c (cmd_set_record_btrace): Print sub-commands.

>>> ---

>>> gdb/record-btrace.c | 5 ++++-

>>> 1 file changed, 4 insertions(+), 1 deletion(-)

>>> 

>>> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index

>>> 48eda54..905f0c4 100644

>>> --- a/gdb/record-btrace.c

>>> +++ b/gdb/record-btrace.c

>>> @@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int

>>> from_tty) static void cmd_set_record_btrace (const char *args, int

>>> from_tty) {

>>> -  cmd_show_list (set_record_btrace_cmdlist, from_tty, "");

>>> +  printf_unfiltered (_("\"set record btrace\" must be followed "

>>> +		       "by an apporpriate subcommand.\n"));

>> 

>> appropriate not apporpriate.

> 

> Thanks.  I'm adding another patch to the series to fix that same typo in the

> "set record" command from where I took the message.  See below.

> 

> Looks like this text is not used in any test (grep did not find anything),

> except for the new gdb.btrace/cpu.exp that 2/2 of this series adds.

> 


New patch LGTM.


> Regards,

> Markus.

> 

> ---

> 

> commit 755376c12a2fa53d8304ff68265a09b8a332e965

> Author: Markus Metzger <markus.t.metzger@intel.com>

> Date:   Mon Mar 5 17:44:57 2018 +0100

> 

>    record: fix typo in "set record" output

> 

>    Alan Hayward pointed out a typo in the output of "set record btrace" that

>    I took from "set record".  Fix the original.

> 

>    Signed-off-by: Markus Metzger  <markus.t.metzger@intel.com>

> 

>    gdb/

>        * record.c (set_record_command): Fix typo in message.

> 

> diff --git a/gdb/record.c b/gdb/record.c

> index cd83b99..aec2be3 100644

> --- a/gdb/record.c

> +++ b/gdb/record.c

> @@ -320,7 +320,7 @@ static void

> set_record_command (const char *args, int from_tty)

> {

>   printf_unfiltered (_("\"set record\" must be followed "

> -                      "by an apporpriate subcommand.\n"));

> +                      "by an appropriate subcommand.\n"));

>   help_list (set_record_cmdlist, "set record ", all_commands, gdb_stdout);

> }

> 

> Intel Deutschland GmbH

> Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany

> Tel: +49 89 99 8853-0, www.intel.de

> Managing Directors: Christin Eisenschmid, Christian Lamprechter

> Chairperson of the Supervisory Board: Nicole Lau

> Registered Office: Munich

> Commercial Register: Amtsgericht Muenchen HRB 186928

>

Patch

diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index 48eda54..905f0c4 100644
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -2953,7 +2953,10 @@  cmd_record_btrace_start (const char *args, int from_tty)
 static void
 cmd_set_record_btrace (const char *args, int from_tty)
 {
-  cmd_show_list (set_record_btrace_cmdlist, from_tty, "");
+  printf_unfiltered (_("\"set record btrace\" must be followed "
+		       "by an apporpriate subcommand.\n"));
+  help_list (set_record_btrace_cmdlist, "set record btrace ",
+	     all_commands, gdb_stdout);
 }
 
 /* The "show record btrace" command.  */