[gdb/testsuite] Use %progbits in watch-loc.c

Message ID 65a57999-129f-c29c-4fd7-af198926cb15@foss.arm.com
State New
Headers show
Series
  • [gdb/testsuite] Use %progbits in watch-loc.c
Related show

Commit Message

Thomas Preudhomme March 1, 2018, 7:02 p.m.
Hi,

While using @progbits in .pushsection work on some targets, it does not
work on arm target where this introduces a comment. This patch replaces
its use in gdb.dlang/watch-loc.c by %progbits which should work on all
targets since it is used in target-independent elf/section7.s GAS test.

ChangeLog entry is as follows:

*** gdb/testsuite/ChangeLog ***

2018-03-01  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.

Is this ok for master?

Best regards,

Thomas

Comments

Yao Qi March 2, 2018, 11:44 a.m. | #1
Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:

> 2018-03-01  Thomas Preud'homme  <thomas.preudhomme@arm.com>

>

> 	* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.


Patch is good to me.  A nit, can you update
gdb.mi/dw2-ref-missing-frame-func.c as well? @progbits is used there as well.

-- 
Yao (齐尧)
Thomas Preudhomme March 2, 2018, 11:54 a.m. | #2
Done. Committed the following:

*** gdb/testsuite/ChangeLog ***

2018-03-02  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.
	* gdb.mi/dw2-ref-missing-frame-func.c: Likewise.

Best regards,

Thomas

On 02/03/18 11:44, Yao Qi wrote:
> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:

> 

>> 2018-03-01  Thomas Preud'homme  <thomas.preudhomme@arm.com>

>>

>> 	* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.

> 

> Patch is good to me.  A nit, can you update

> gdb.mi/dw2-ref-missing-frame-func.c as well? @progbits is used there as well.

>
diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c
index 06fcc8922b43712dd36ce84600203427477ff69d..46810bcd2372ebc69c4c66e46ec9ee5b80f98b1a 100644
--- a/gdb/testsuite/gdb.dlang/watch-loc.c
+++ b/gdb/testsuite/gdb.dlang/watch-loc.c
@@ -38,7 +38,7 @@ main (void)
    generated by GCC.  (.gdb_index includes a gdb-generated map
    instead.)  */
 asm (
-"	.pushsection	.debug_aranges,\"\",@progbits \n"
+"	.pushsection	.debug_aranges,\"\",%progbits \n"
 "	.4byte	.Laranges_end - .Laranges_start \n"	// Length of Address Ranges Info
 ".Laranges_start: \n"
 "	.2byte	0x2 \n"	// DWARF Version
diff --git a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c
index c6edff851e179207a59ae69848b0e67d77666365..c0800e980f5601001de37c8f6260a79415f581ae 100644
--- a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c
+++ b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c
@@ -57,7 +57,7 @@ asm ("cu_text_end:");
    generated by GCC.  (.gdb_index includes a gdb-generated map
    instead.)  */
 asm (
-"	.pushsection	.debug_aranges,\"\",@progbits \n"
+"	.pushsection	.debug_aranges,\"\",%progbits \n"
 "	.4byte	.Laranges_end - .Laranges_start \n"	// Length of Address Ranges Info
 ".Laranges_start: \n"
 "	.2byte	0x2 \n"	// DWARF Version

Patch

diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c
index 06fcc8922b43712dd36ce84600203427477ff69d..46810bcd2372ebc69c4c66e46ec9ee5b80f98b1a 100644
--- a/gdb/testsuite/gdb.dlang/watch-loc.c
+++ b/gdb/testsuite/gdb.dlang/watch-loc.c
@@ -38,7 +38,7 @@  main (void)
    generated by GCC.  (.gdb_index includes a gdb-generated map
    instead.)  */
 asm (
-"	.pushsection	.debug_aranges,\"\",@progbits \n"
+"	.pushsection	.debug_aranges,\"\",%progbits \n"
 "	.4byte	.Laranges_end - .Laranges_start \n"	// Length of Address Ranges Info
 ".Laranges_start: \n"
 "	.2byte	0x2 \n"	// DWARF Version