[committed] MIPS/include: opcode/mips.h: Update stale comment for CODE20 operand

Message ID alpine.LFD.2.21.1904250051470.18194@eddie.linux-mips.org
State New
Headers show
Series
  • [committed] MIPS/include: opcode/mips.h: Update stale comment for CODE20 operand
Related show

Commit Message

Maciej W. Rozycki April 25, 2019, 12:38 a.m.
Complement commit 1586d91e32ea ("/ 0 should send SIGFPE not SIGTRAP..."), 
<https://sourceware.org/ml/binutils/2004-07/msg00260.html>, and update a 
stale comment referring the 20-bit code field of the BREAK and SDBBP 
instructions, by making it explicit that where permitted by choosing the 
MIPS32 or a later ISA the whole field can now be set with a single 
operand for the SDBBP instruction only.

	include/
	* opcode/mips.h: Update comment for MIPS32 CODE20 operand.
---
Hi,

 I guess the SDBBP instruction would preferably also assemble consistently 
between ISA levels, but nobody has noticed any problems for so many years, 
perhaps because the R3900 is so uncommon, so I think it may be best left 
untouched.

  Maciej
---
 include/opcode/mips.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

binutils-opcodes-code20-comment.diff

Patch

Index: src/include/opcode/mips.h
===================================================================
--- src.orig/include/opcode/mips.h
+++ src/include/opcode/mips.h
@@ -56,8 +56,8 @@  extern "C" {
    code field in BREAK is 20 bits; yet MIPS assemblers and debuggers
    only use ten bits).  An optional two-operand form of break/sdbbp
    allows the lower ten bits to be set too, and MIPS32 and later
-   architectures allow 20 bits to be set with a signal operand
-   (using CODE20).
+   architectures allow 20 bits to be set with a single operand for
+   the sdbbp instruction (using CODE20).
 
    The syscall instruction uses CODE20.