[0/5] xtensa: fix for ld and testsuite improvements

Message ID 20180723181030.11632-1-jcmvbkbc@gmail.com
Headers show
Series
  • xtensa: fix for ld and testsuite improvements
Related show

Message

Max Filippov July 23, 2018, 6:10 p.m.
Hello,

this series fixes a bug in relaxation of references to undefined weak
dynamic symbols in shared objects on xtensa, rearranges ld-xtensa
testsuite and adds new tests for relaxation in dynamic objects.

Max Filippov (5):
  xtensa: fix relaxation of undefined weak references in shared objects
  xtensa: move dynamic relocations sections consistency check
  xtensa: ld: rename xtensa.exp to xtensa-linux.exp
  xtensa: ld: add tests for static linkage relaxation
  xtensa: ld: convert tests to run_dump_test

 bfd/elf32-xtensa.c                                 |  25 ++---
 ld/testsuite/ld-xtensa/coalesce.d                  |   7 ++
 ld/testsuite/ld-xtensa/coalesce.exp                |  99 ------------------
 ld/testsuite/ld-xtensa/diff_overflow.d             |   6 ++
 ld/testsuite/ld-xtensa/diff_overflow.exp           |  45 --------
 ld/testsuite/ld-xtensa/lcall.d                     |  10 ++
 ld/testsuite/ld-xtensa/lcall.exp                   | 113 ---------------------
 ld/testsuite/ld-xtensa/relax-static-defs.s         |  33 ++++++
 ld/testsuite/ld-xtensa/relax-static-local-pie.d    |  17 ++++
 ld/testsuite/ld-xtensa/relax-static-local-shared.d |  17 ++++
 ld/testsuite/ld-xtensa/relax-static-local.s        |  19 ++++
 ld/testsuite/ld-xtensa/relax-static-pie.d          |  13 +++
 ld/testsuite/ld-xtensa/relax-static-shared.d       |  15 +++
 ld/testsuite/ld-xtensa/relax-static.s              |   9 ++
 .../ld-xtensa/relax-undef-weak-local-pie.d         |   6 ++
 .../ld-xtensa/relax-undef-weak-local-shared.d      |   6 ++
 ld/testsuite/ld-xtensa/relax-undef-weak-local.s    |  31 ++++++
 ld/testsuite/ld-xtensa/relax-undef-weak-pie.d      |   6 ++
 ld/testsuite/ld-xtensa/relax-undef-weak-shared.d   |  14 +++
 ld/testsuite/ld-xtensa/relax-undef-weak.s          |  12 +++
 ld/testsuite/ld-xtensa/xtensa-linux.exp            |  56 ++++++++++
 ld/testsuite/ld-xtensa/xtensa.exp                  |  42 +++-----
 22 files changed, 302 insertions(+), 299 deletions(-)
 create mode 100644 ld/testsuite/ld-xtensa/coalesce.d
 delete mode 100644 ld/testsuite/ld-xtensa/coalesce.exp
 create mode 100644 ld/testsuite/ld-xtensa/diff_overflow.d
 delete mode 100644 ld/testsuite/ld-xtensa/diff_overflow.exp
 create mode 100644 ld/testsuite/ld-xtensa/lcall.d
 delete mode 100644 ld/testsuite/ld-xtensa/lcall.exp
 create mode 100644 ld/testsuite/ld-xtensa/relax-static-defs.s
 create mode 100644 ld/testsuite/ld-xtensa/relax-static-local-pie.d
 create mode 100644 ld/testsuite/ld-xtensa/relax-static-local-shared.d
 create mode 100644 ld/testsuite/ld-xtensa/relax-static-local.s
 create mode 100644 ld/testsuite/ld-xtensa/relax-static-pie.d
 create mode 100644 ld/testsuite/ld-xtensa/relax-static-shared.d
 create mode 100644 ld/testsuite/ld-xtensa/relax-static.s
 create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local-pie.d
 create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local-shared.d
 create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local.s
 create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-pie.d
 create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-shared.d
 create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak.s
 create mode 100644 ld/testsuite/ld-xtensa/xtensa-linux.exp

-- 
2.11.0

Comments

augustine.sterling@gmail.com July 23, 2018, 6:46 p.m. | #1
On Mon, Jul 23, 2018 at 11:10 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> Hello,

>

> this series fixes a bug in relaxation of references to undefined weak

> dynamic symbols in shared objects on xtensa, rearranges ld-xtensa

> testsuite and adds new tests for relaxation in dynamic objects.

>


This series is acceptable. I'll reply to the individual patches also.


> Max Filippov (5):

>   xtensa: fix relaxation of undefined weak references in shared objects

>   xtensa: move dynamic relocations sections consistency check

>   xtensa: ld: rename xtensa.exp to xtensa-linux.exp

>   xtensa: ld: add tests for static linkage relaxation

>   xtensa: ld: convert tests to run_dump_test

>

>  bfd/elf32-xtensa.c                                 |  25 ++---

>  ld/testsuite/ld-xtensa/coalesce.d                  |   7 ++

>  ld/testsuite/ld-xtensa/coalesce.exp                |  99 ------------------

>  ld/testsuite/ld-xtensa/diff_overflow.d             |   6 ++

>  ld/testsuite/ld-xtensa/diff_overflow.exp           |  45 --------

>  ld/testsuite/ld-xtensa/lcall.d                     |  10 ++

>  ld/testsuite/ld-xtensa/lcall.exp                   | 113 ---------------------

>  ld/testsuite/ld-xtensa/relax-static-defs.s         |  33 ++++++

>  ld/testsuite/ld-xtensa/relax-static-local-pie.d    |  17 ++++

>  ld/testsuite/ld-xtensa/relax-static-local-shared.d |  17 ++++

>  ld/testsuite/ld-xtensa/relax-static-local.s        |  19 ++++

>  ld/testsuite/ld-xtensa/relax-static-pie.d          |  13 +++

>  ld/testsuite/ld-xtensa/relax-static-shared.d       |  15 +++

>  ld/testsuite/ld-xtensa/relax-static.s              |   9 ++

>  .../ld-xtensa/relax-undef-weak-local-pie.d         |   6 ++

>  .../ld-xtensa/relax-undef-weak-local-shared.d      |   6 ++

>  ld/testsuite/ld-xtensa/relax-undef-weak-local.s    |  31 ++++++

>  ld/testsuite/ld-xtensa/relax-undef-weak-pie.d      |   6 ++

>  ld/testsuite/ld-xtensa/relax-undef-weak-shared.d   |  14 +++

>  ld/testsuite/ld-xtensa/relax-undef-weak.s          |  12 +++

>  ld/testsuite/ld-xtensa/xtensa-linux.exp            |  56 ++++++++++

>  ld/testsuite/ld-xtensa/xtensa.exp                  |  42 +++-----

>  22 files changed, 302 insertions(+), 299 deletions(-)

>  create mode 100644 ld/testsuite/ld-xtensa/coalesce.d

>  delete mode 100644 ld/testsuite/ld-xtensa/coalesce.exp

>  create mode 100644 ld/testsuite/ld-xtensa/diff_overflow.d

>  delete mode 100644 ld/testsuite/ld-xtensa/diff_overflow.exp

>  create mode 100644 ld/testsuite/ld-xtensa/lcall.d

>  delete mode 100644 ld/testsuite/ld-xtensa/lcall.exp

>  create mode 100644 ld/testsuite/ld-xtensa/relax-static-defs.s

>  create mode 100644 ld/testsuite/ld-xtensa/relax-static-local-pie.d

>  create mode 100644 ld/testsuite/ld-xtensa/relax-static-local-shared.d

>  create mode 100644 ld/testsuite/ld-xtensa/relax-static-local.s

>  create mode 100644 ld/testsuite/ld-xtensa/relax-static-pie.d

>  create mode 100644 ld/testsuite/ld-xtensa/relax-static-shared.d

>  create mode 100644 ld/testsuite/ld-xtensa/relax-static.s

>  create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local-pie.d

>  create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local-shared.d

>  create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local.s

>  create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-pie.d

>  create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-shared.d

>  create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak.s

>  create mode 100644 ld/testsuite/ld-xtensa/xtensa-linux.exp

>

> --

> 2.11.0

>
Max Filippov July 23, 2018, 7:13 p.m. | #2
On Mon, Jul 23, 2018 at 11:46 AM, augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
> On Mon, Jul 23, 2018 at 11:10 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:

>> Hello,

>>

>> this series fixes a bug in relaxation of references to undefined weak

>> dynamic symbols in shared objects on xtensa, rearranges ld-xtensa

>> testsuite and adds new tests for relaxation in dynamic objects.

>>

>

> This series is acceptable. I'll reply to the individual patches also.


Thanks, applied whole series to the master.
I'll also backport the fix to the branch binutils-2_31-branch after a while.

-- Max