[PATCHv2,0/4] Supply additional default gdbarch methods

Message ID cover.1521149611.git.andrew.burgess@embecosm.com
Headers show
Series
  • Supply additional default gdbarch methods
Related show

Message

Andrew Burgess March 15, 2018, 9:51 p.m.
This revision follows up on Simon's feedback.

Patch #1 has been extended to cover aarch64 and sparc.

Patch #2 rewrites default_unwind_pc as suggested, and allows even more
targets to use the default.

Patch #3 adds a default_dummy_id.

Patch #4 adds a default_unwind_sp.

For testing I've built a wide range of targets, I believe that most of
the targets I've touched have been built.

I've tested on x86-64 GNU/Linux (though that target hasn't changed),
and I've also run this patch through buildbot without issue.

Is there any additional testing I should run?

All feedback appreciated.

Thanks,
Andrew

---

Andrew Burgess (4):
  gdb: Add a default_unwind_pc method for gdbarch
  gdb: Remove more targets unwind_pc methods
  gdb: Supply a default for gdbarch_dummy_id
  gdb: Supply default gdbarch_unwind_sp and use where possible

 gdb/ChangeLog        | 221 +++++++++++++++++++++++++++++++++++++++++++++++++++
 gdb/aarch64-tdep.c   |  38 ---------
 gdb/alpha-tdep.c     |  29 -------
 gdb/arc-tdep.c       |  14 ----
 gdb/arm-tdep.c       |  37 ---------
 gdb/bfin-tdep.c      |  18 -----
 gdb/cris-tdep.c      |  40 ----------
 gdb/dummy-frame.c    |  16 ++++
 gdb/dummy-frame.h    |   6 ++
 gdb/frame-unwind.c   |  32 ++++++++
 gdb/frame-unwind.h   |  12 +++
 gdb/frame.c          | 132 ++++++++++++++----------------
 gdb/frv-tdep.c       |  27 -------
 gdb/ft32-tdep.c      |  33 --------
 gdb/gdbarch.c        |  41 ++--------
 gdb/gdbarch.h        |   6 --
 gdb/gdbarch.sh       |   8 +-
 gdb/h8300-tdep.c     |  22 -----
 gdb/hppa-tdep.c      |   9 ---
 gdb/i386-tdep.c      |  13 ---
 gdb/iq2000-tdep.c    |  22 -----
 gdb/lm32-tdep.c      |  23 ------
 gdb/m32r-tdep.c      |  37 ---------
 gdb/m68hc11-tdep.c   |  24 ------
 gdb/m68k-tdep.c      |  10 ---
 gdb/m88k-tdep.c      |  21 -----
 gdb/mep-tdep.c       |  30 -------
 gdb/mn10300-tdep.c   |  32 +-------
 gdb/moxie-tdep.c     |  33 --------
 gdb/msp430-tdep.c    |  31 --------
 gdb/nds32-tdep.c     |  29 -------
 gdb/nios2-tdep.c     |  35 +-------
 gdb/or1k-tdep.c      |  10 ---
 gdb/riscv-tdep.c     |  30 -------
 gdb/rl78-tdep.c      |  20 -----
 gdb/rs6000-tdep.c    |  19 -----
 gdb/rx-tdep.c        |  33 --------
 gdb/s390-tdep.c      |  12 ---
 gdb/score-tdep.c     |  23 ------
 gdb/sh-tdep.c        |  25 ------
 gdb/sh64-tdep.c      |  25 ------
 gdb/sparc-tdep.c     |   9 ---
 gdb/tic6x-tdep.c     |  35 --------
 gdb/tilegx-tdep.c    |  26 ------
 gdb/v850-tdep.c      |  25 ------
 gdb/vax-tdep.c       |   8 --
 gdb/xstormy16-tdep.c |  23 ------
 47 files changed, 361 insertions(+), 1043 deletions(-)

-- 
2.14.3

Comments

Andrew Burgess April 10, 2018, 10:13 a.m. | #1
Ping.

Thanks,
Andrew

* Andrew Burgess <andrew.burgess@embecosm.com> [2018-03-15 21:51:20 +0000]:

> This revision follows up on Simon's feedback.

> 

> Patch #1 has been extended to cover aarch64 and sparc.

> 

> Patch #2 rewrites default_unwind_pc as suggested, and allows even more

> targets to use the default.

> 

> Patch #3 adds a default_dummy_id.

> 

> Patch #4 adds a default_unwind_sp.

> 

> For testing I've built a wide range of targets, I believe that most of

> the targets I've touched have been built.

> 

> I've tested on x86-64 GNU/Linux (though that target hasn't changed),

> and I've also run this patch through buildbot without issue.

> 

> Is there any additional testing I should run?

> 

> All feedback appreciated.

> 

> Thanks,

> Andrew

> 

> ---

> 

> Andrew Burgess (4):

>   gdb: Add a default_unwind_pc method for gdbarch

>   gdb: Remove more targets unwind_pc methods

>   gdb: Supply a default for gdbarch_dummy_id

>   gdb: Supply default gdbarch_unwind_sp and use where possible

> 

>  gdb/ChangeLog        | 221 +++++++++++++++++++++++++++++++++++++++++++++++++++

>  gdb/aarch64-tdep.c   |  38 ---------

>  gdb/alpha-tdep.c     |  29 -------

>  gdb/arc-tdep.c       |  14 ----

>  gdb/arm-tdep.c       |  37 ---------

>  gdb/bfin-tdep.c      |  18 -----

>  gdb/cris-tdep.c      |  40 ----------

>  gdb/dummy-frame.c    |  16 ++++

>  gdb/dummy-frame.h    |   6 ++

>  gdb/frame-unwind.c   |  32 ++++++++

>  gdb/frame-unwind.h   |  12 +++

>  gdb/frame.c          | 132 ++++++++++++++----------------

>  gdb/frv-tdep.c       |  27 -------

>  gdb/ft32-tdep.c      |  33 --------

>  gdb/gdbarch.c        |  41 ++--------

>  gdb/gdbarch.h        |   6 --

>  gdb/gdbarch.sh       |   8 +-

>  gdb/h8300-tdep.c     |  22 -----

>  gdb/hppa-tdep.c      |   9 ---

>  gdb/i386-tdep.c      |  13 ---

>  gdb/iq2000-tdep.c    |  22 -----

>  gdb/lm32-tdep.c      |  23 ------

>  gdb/m32r-tdep.c      |  37 ---------

>  gdb/m68hc11-tdep.c   |  24 ------

>  gdb/m68k-tdep.c      |  10 ---

>  gdb/m88k-tdep.c      |  21 -----

>  gdb/mep-tdep.c       |  30 -------

>  gdb/mn10300-tdep.c   |  32 +-------

>  gdb/moxie-tdep.c     |  33 --------

>  gdb/msp430-tdep.c    |  31 --------

>  gdb/nds32-tdep.c     |  29 -------

>  gdb/nios2-tdep.c     |  35 +-------

>  gdb/or1k-tdep.c      |  10 ---

>  gdb/riscv-tdep.c     |  30 -------

>  gdb/rl78-tdep.c      |  20 -----

>  gdb/rs6000-tdep.c    |  19 -----

>  gdb/rx-tdep.c        |  33 --------

>  gdb/s390-tdep.c      |  12 ---

>  gdb/score-tdep.c     |  23 ------

>  gdb/sh-tdep.c        |  25 ------

>  gdb/sh64-tdep.c      |  25 ------

>  gdb/sparc-tdep.c     |   9 ---

>  gdb/tic6x-tdep.c     |  35 --------

>  gdb/tilegx-tdep.c    |  26 ------

>  gdb/v850-tdep.c      |  25 ------

>  gdb/vax-tdep.c       |   8 --

>  gdb/xstormy16-tdep.c |  23 ------

>  47 files changed, 361 insertions(+), 1043 deletions(-)

> 

> -- 

> 2.14.3

>