[00/15] More TUI Refactorings

Message ID 20190821022535.9762-1-tom@tromey.com
Headers show
Series
  • More TUI Refactorings
Related show

Message

Tom Tromey Aug. 21, 2019, 2:25 a.m.
Here is another series of TUI refactorings.  There should be no
user-visible changes in this series (patch #1 changes a message, but I
don't believe it can actually be seen).

I tested each one using the gdb.tui tests.  This worked here, though
as we learned recently, at least empty.exp is not very reliable.

There's about one more series of this size waiting to be submitted,
plus one (or maybe two) patches that change the TUI in small
user-visible ways.

Tom

Comments

Pedro Alves Aug. 26, 2019, 2:07 p.m. | #1
On 8/21/19 3:25 AM, Tom Tromey wrote:
> Here is another series of TUI refactorings.  There should be no

> user-visible changes in this series (patch #1 changes a message, but I

> don't believe it can actually be seen).

> 

> I tested each one using the gdb.tui tests.  This worked here, though

> as we learned recently, at least empty.exp is not very reliable.

> 

> There's about one more series of this size waiting to be submitted,

> plus one (or maybe two) patches that change the TUI in small

> user-visible ways.


LGTM.  

Nice to see the number of rerender/refresh methods down.

Thanks,
Pedro Alves
Tom Tromey Aug. 30, 2019, 7:05 p.m. | #2
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:


Pedro> On 8/21/19 3:25 AM, Tom Tromey wrote:
>> Here is another series of TUI refactorings.  There should be no

>> user-visible changes in this series (patch #1 changes a message, but I

>> don't believe it can actually be seen).

>> 

>> I tested each one using the gdb.tui tests.  This worked here, though

>> as we learned recently, at least empty.exp is not very reliable.

>> 

>> There's about one more series of this size waiting to be submitted,

>> plus one (or maybe two) patches that change the TUI in small

>> user-visible ways.


Pedro> LGTM.  

Thanks.  I'm checking this in now.

Tom