[v4,0/2] MI: Add new command -complete

Message ID 20190418115847.19854-1-jan.vrany@fit.cvut.cz
Headers show
Series
  • MI: Add new command -complete
Related show

Message

Jan Vrany April 18, 2019, 11:58 a.m.
This is a rework of v3 patch based on further Pedro's comments
and on Eli's comments

Differences v3 -> v4:

  * fixed "few nits" based on Petro's comments
  * fixed/improved documentation based on Eli's comments

Differences v2 -> v3:

  * to support wildmatching, the command output had to change to
    provide both, "completion" (what a frontend should complete)
    and "matches" (a list of possible completions)
  * and some formatting issues.

Differences v1 -> v2:

  * extracted common completion logic to a new helper function
  * implemented MI command using a new mi-specific function rather
    than using CLI implementation.


Jan Vrany (2):
  MI: extract command completion logic from complete_command()
  MI: Add new command -complete

 gdb/ChangeLog                        | 14 ++++++
 gdb/NEWS                             |  7 +++
 gdb/cli/cli-cmds.c                   | 29 +----------
 gdb/completer.c                      | 35 ++++++++++++++
 gdb/completer.h                      |  7 +++
 gdb/doc/ChangeLog                    |  5 ++
 gdb/doc/gdb.texinfo                  | 61 +++++++++++++++++++++++
 gdb/mi/mi-cmds.c                     |  1 +
 gdb/mi/mi-cmds.h                     |  1 +
 gdb/mi/mi-main.c                     | 45 +++++++++++++++++
 gdb/testsuite/ChangeLog              |  5 ++
 gdb/testsuite/gdb.mi/mi-complete.cc  | 40 ++++++++++++++++
 gdb/testsuite/gdb.mi/mi-complete.exp | 72 ++++++++++++++++++++++++++++
 13 files changed, 294 insertions(+), 28 deletions(-)
 create mode 100644 gdb/testsuite/gdb.mi/mi-complete.cc
 create mode 100644 gdb/testsuite/gdb.mi/mi-complete.exp

-- 
2.20.1