[v3,00/17] Remove some cleanups using scope_exit

Message ID 20190123152131.29893-1-palves@redhat.com
Headers show
Series
  • Remove some cleanups using scope_exit
Related show

Message

Pedro Alves Jan. 23, 2019, 3:21 p.m.
Here's the new version of Tromey's "cleanup function" series, updated
to use the new scope_exit instead.

v1 was here:
  https://sourceware.org/ml/gdb-patches/2019-01/msg00159.html

I'm calling Andrew's patches the "v2":
  https://sourceware.org/ml/gdb-patches/2019-01/msg00273.html

The discussion around "v2" led to this version.

New in v3:

   - cleanup_function is replaced with a new scope_exit template
     class.  scope_exit is a general-purpose scope guard that calls
     its exit function at the end of the current scope.  Unlike the
     original cleanup_function, scope_exit is a template, and saves
     the callable internaly (function pointer, function object,
     lambda) instead of using gdb::function_view.  This leads to a bit
     more natural syntax, since there's no need to worry about
     lifetime of the callable.  Also, being a template, there's no
     heap involved, unlike if we used std::function.

   - forward_scope_exit is new.  The idea is based on Andrew's here:
      https://sourceware.org/ml/gdb-patches/2019-01/msg00273.html
     though the implementation is different, and this version ends up
     with a simpler user interface.

   - Patches #1 and #5 are new.

   - Patches #8 and #9 and swapped compared to the original series,
     and a cleanup conversion was moved between the patches.

   - Patch #7 removes a bit more comment than the previous version.

   - Series updated throughout to use
     scope_exit/SCOPE_EXIT/make_scope_exit/forward_scope_exit as
     appropriate.

Pedro Alves (6):
  Rename ESC -> ESC_PARENS
  Introduce scope_exit
  Introduce forward_scope_exit
  Use forward_scope_exit for scoped_finish_thread_state
  Use SCOPE_EXIT in gdbarch-selftest.c
  Remove clear_symtab_users_cleanup

Tom Tromey (11):
  Replace delete_longjmp_breakpoint_cleanup with a forward_scope_exit
    type
  Remove remaining cleanup from gdb/breakpoint.c
  Remove delete_just_stopped_threads_infrun_breakpoints_cleanup
  Remove make_bpstat_clear_actions_cleanup
  Remove cleanup_delete_std_terminate_breakpoint
  Remove cleanup from linux-nat.c
  Remove cleanup from stop_all_threads
  Remove remaining cleanup from fetch_inferior_event
  Update an obsolete cleanup comment
  Update cleanup comment in ui-out.h
  Use scope_exit in regcache.c

 gdb/breakpoint.c                |  27 ++---
 gdb/common/forward-scope-exit.h | 123 +++++++++++++++++++++
 gdb/common/preprocessor.h       |   2 +-
 gdb/common/scope-exit.h         | 186 ++++++++++++++++++++++++++++++++
 gdb/common/valid-expr.h         |  18 ++--
 gdb/gdbarch-selftests.c         |   8 +-
 gdb/gdbthread.h                 |  28 +----
 gdb/infcall.c                   |  13 +--
 gdb/infcmd.c                    |  12 +--
 gdb/inferior.h                  |   4 +-
 gdb/infrun.c                    | 230 ++++++++++++++++++----------------------
 gdb/linux-nat.c                 |  18 +---
 gdb/regcache.c                  |  34 +-----
 gdb/symfile.c                   |  24 ++---
 gdb/top.c                       |   8 +-
 gdb/ui-out.h                    |   8 +-
 gdb/utils.c                     |  17 ---
 gdb/utils.h                     |   1 -
 18 files changed, 465 insertions(+), 296 deletions(-)
 create mode 100644 gdb/common/forward-scope-exit.h
 create mode 100644 gdb/common/scope-exit.h

-- 
2.14.4

Comments

Tom Tromey Jan. 23, 2019, 5:32 p.m. | #1
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:


Pedro> Here's the new version of Tromey's "cleanup function" series, updated
Pedro> to use the new scope_exit instead.

Pedro> v1 was here:
Pedro>   https://sourceware.org/ml/gdb-patches/2019-01/msg00159.html

Pedro> I'm calling Andrew's patches the "v2":
Pedro>   https://sourceware.org/ml/gdb-patches/2019-01/msg00273.html

Pedro> The discussion around "v2" led to this version.

Thanks for doing this.  I read through the patches again and everything
looks good to me.  There was one tiny nit in a commit message.

Tom
Pedro Alves Jan. 23, 2019, 7:18 p.m. | #2
On 01/23/2019 05:32 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

> 

> Pedro> Here's the new version of Tromey's "cleanup function" series, updated

> Pedro> to use the new scope_exit instead.

> 

> Pedro> v1 was here:

> Pedro>   https://sourceware.org/ml/gdb-patches/2019-01/msg00159.html

> 

> Pedro> I'm calling Andrew's patches the "v2":

> Pedro>   https://sourceware.org/ml/gdb-patches/2019-01/msg00273.html

> 

> Pedro> The discussion around "v2" led to this version.

> 

> Thanks for doing this.  I read through the patches again and everything

> looks good to me.  There was one tiny nit in a commit message.

Alright, I fixed the typo and pushed it in.

Thanks,
Pedro Alves