Couple of minor tweaks to the linker testsuite

Message ID 35741193.VhfVxWHZFs@polaris
State New
Headers show
Series
  • Couple of minor tweaks to the linker testsuite
Related show

Commit Message

Eric Botcazou Sept. 12, 2018, 7:56 a.m.
Hi,

this gets rid of the couple of linker failures for visium-elf:

FAIL: ld-elf/pr14156b
FAIL: ld-elf/pr22677

by tweaking the respective testcase.  The first tweak is the same as the one 
Alan made to the sibling testcase ld-elf/pr14156a.d about one year ago and the 
second tweak adds the usual main/start/_start/__start symbols.

Tested for visium-elf and x86_64-suse-linux, OK for the mainline?


2018-09-12  Eric Botcazou  <ebotcazou@adacore.com>

ld/
	* testsuite/ld-elf/pr14156b.d: Adjust for extra symbols.
	* testsuite/ld-elf/pr22677.s: Define main/start/_start/__start.

-- 
Eric Botcazou

Comments

Nick Clifton Sept. 17, 2018, 3:22 p.m. | #1
Hi Eric,

> 2018-09-12  Eric Botcazou  <ebotcazou@adacore.com>

> 

> ld/

> 	* testsuite/ld-elf/pr14156b.d: Adjust for extra symbols.

> 	* testsuite/ld-elf/pr22677.s: Define main/start/_start/__start.


Approved - please apply.

Cheers
  Nick

Patch

diff --git a/ld/testsuite/ld-elf/pr14156b.d b/ld/testsuite/ld-elf/pr14156b.d
index 07c72b054e..1cd16c021b 100644
--- a/ld/testsuite/ld-elf/pr14156b.d
+++ b/ld/testsuite/ld-elf/pr14156b.d
@@ -10,6 +10,7 @@ 
 #...
 [0-9a-f]+ T foo
 [0-9a-f]+ t foo1
+#...
 [0-9a-f]+ t foo2
 [0-9a-f]+ t foo3
 [0-9a-f]+ t last
diff --git a/ld/testsuite/ld-elf/pr22677.s b/ld/testsuite/ld-elf/pr22677.s
index 16f8bc3149..3941584448 100644
--- a/ld/testsuite/ld-elf/pr22677.s
+++ b/ld/testsuite/ld-elf/pr22677.s
@@ -10,7 +10,15 @@ 
 	.p2align 2
 	.word 0
 
-	.text
+	.globl main
+	.globl start
+	.globl _start
+	.globl __start
 	.globl foo
+	.text
+main:
+start:
+_start:
+__start:
 foo:
 	.word 0