Fix broken capitalization in aarch64 diagnostics

Message ID 20171211172907.GP2353@tucnak
State New
Headers show
Series
  • Fix broken capitalization in aarch64 diagnostics
Related show

Commit Message

Jakub Jelinek Dec. 11, 2017, 5:29 p.m.
Hi!

Diagnostics should not start with capital letters unless the first word is
capitalized that way even in the middle of a sentence.

Fixed thusly, ok for trunk?

2017-12-11  Jakub Jelinek  <jakub@redhat.com>

	* config/aarch64/aarch64.c (aarch64_print_operand): Don't start
	output_operand_lossage first argument with capital letter.
	(aarch64_override_options): Don't start error and sorry first argument
	with capital letter.


	Jakub

Comments

Richard Biener Dec. 11, 2017, 5:55 p.m. | #1
On December 11, 2017 6:29:07 PM GMT+01:00, Jakub Jelinek <jakub@redhat.com> wrote:
>Hi!

>

>Diagnostics should not start with capital letters unless the first word

>is

>capitalized that way even in the middle of a sentence.

>

>Fixed thusly, ok for trunk?


OK. 

Richard. 

>2017-12-11  Jakub Jelinek  <jakub@redhat.com>

>

>	* config/aarch64/aarch64.c (aarch64_print_operand): Don't start

>	output_operand_lossage first argument with capital letter.

>	(aarch64_override_options): Don't start error and sorry first argument

>	with capital letter.

>

>--- gcc/config/aarch64/aarch64.c.jj	2017-12-08 00:50:28.000000000 +0100

>+++ gcc/config/aarch64/aarch64.c	2017-12-11 17:54:13.281833956 +0100

>@@ -5258,7 +5258,7 @@ aarch64_print_operand (FILE *f, rtx x, i

> 	  /* Fall through.  */

> 

> 	default:

>-	  output_operand_lossage ("Unsupported operand for code '%c'", code);

>+	  output_operand_lossage ("unsupported operand for code '%c'", code);

> 	}

>       break;

> 

>@@ -9404,11 +9404,11 @@ aarch64_override_options (void)

>/* The compiler may have been configured with 2.23.* binutils, which

>does

>      not have support for ILP32.  */

>   if (TARGET_ILP32)

>-    error ("Assembler does not support -mabi=ilp32");

>+    error ("assembler does not support -mabi=ilp32");

> #endif

> 

>   if (aarch64_ra_sign_scope != AARCH64_FUNCTION_NONE && TARGET_ILP32)

>-    sorry ("Return address signing is only supported for -mabi=lp64");

>+    sorry ("return address signing is only supported for -mabi=lp64");

> 

>   /* Make sure we properly set up the explicit options.  */

>   if ((aarch64_cpu_string && valid_cpu)

>

>	Jakub
Martin Sebor Dec. 12, 2017, 4:31 a.m. | #2
On 12/11/2017 10:29 AM, Jakub Jelinek wrote:
> Hi!

>

> Diagnostics should not start with capital letters unless the first word is

> capitalized that way even in the middle of a sentence.

>

> Fixed thusly, ok for trunk?

>

> 2017-12-11  Jakub Jelinek  <jakub@redhat.com>

>

> 	* config/aarch64/aarch64.c (aarch64_print_operand): Don't start

> 	output_operand_lossage first argument with capital letter.

> 	(aarch64_override_options): Don't start error and sorry first argument

> 	with capital letter.

>

> --- gcc/config/aarch64/aarch64.c.jj	2017-12-08 00:50:28.000000000 +0100

> +++ gcc/config/aarch64/aarch64.c	2017-12-11 17:54:13.281833956 +0100

> @@ -5258,7 +5258,7 @@ aarch64_print_operand (FILE *f, rtx x, i

>  	  /* Fall through.  */

>

>  	default:

> -	  output_operand_lossage ("Unsupported operand for code '%c'", code);

> +	  output_operand_lossage ("unsupported operand for code '%c'", code);

>  	}

>        break;

>

> @@ -9404,11 +9404,11 @@ aarch64_override_options (void)

>    /* The compiler may have been configured with 2.23.* binutils, which does

>       not have support for ILP32.  */

>    if (TARGET_ILP32)

> -    error ("Assembler does not support -mabi=ilp32");

> +    error ("assembler does not support -mabi=ilp32");


Just a reminder that fixing diagnostic nits like these is
an opportunity to also add the missing quotes around option
names.

Martin

>  #endif

>

>    if (aarch64_ra_sign_scope != AARCH64_FUNCTION_NONE && TARGET_ILP32)

> -    sorry ("Return address signing is only supported for -mabi=lp64");

> +    sorry ("return address signing is only supported for -mabi=lp64");

>

>    /* Make sure we properly set up the explicit options.  */

>    if ((aarch64_cpu_string && valid_cpu)

>

> 	Jakub

>

Patch

--- gcc/config/aarch64/aarch64.c.jj	2017-12-08 00:50:28.000000000 +0100
+++ gcc/config/aarch64/aarch64.c	2017-12-11 17:54:13.281833956 +0100
@@ -5258,7 +5258,7 @@  aarch64_print_operand (FILE *f, rtx x, i
 	  /* Fall through.  */
 
 	default:
-	  output_operand_lossage ("Unsupported operand for code '%c'", code);
+	  output_operand_lossage ("unsupported operand for code '%c'", code);
 	}
       break;
 
@@ -9404,11 +9404,11 @@  aarch64_override_options (void)
   /* The compiler may have been configured with 2.23.* binutils, which does
      not have support for ILP32.  */
   if (TARGET_ILP32)
-    error ("Assembler does not support -mabi=ilp32");
+    error ("assembler does not support -mabi=ilp32");
 #endif
 
   if (aarch64_ra_sign_scope != AARCH64_FUNCTION_NONE && TARGET_ILP32)
-    sorry ("Return address signing is only supported for -mabi=lp64");
+    sorry ("return address signing is only supported for -mabi=lp64");
 
   /* Make sure we properly set up the explicit options.  */
   if ((aarch64_cpu_string && valid_cpu)