[arm] Fix gcc.target/arm/pr40956.c

Message ID 5A61C7A6.7020402@foss.arm.com
State New
Headers show
Series
  • [arm] Fix gcc.target/arm/pr40956.c
Related show

Commit Message

Kyrill Tkachov Jan. 19, 2018, 10:25 a.m.
Hi all,

The scan-assembler tests here check for MOVS for Thumb1 and MOV for Thumb2,
but in fact there's no reason why we wouldn't generate MOVS for Thumb2 as well,
it really depends on a lot of optimisation decisions.
The only behaviour we want to test is that we move a 0 constant into a register
only once, which can be achieved with either MOV or MOVS.
Simplify the check by always checking for either MOV or MOVS.

Committing to trunk.
Thanks,
Kyrill

2018-01-19  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * gcc.target/arm/pr40956.c: Adjust scan-assembler pattern.

Patch

diff --git a/gcc/testsuite/gcc.target/arm/pr40956.c b/gcc/testsuite/gcc.target/arm/pr40956.c
index 4fefa49a5878a90e3a78db7d3df1015a36d0897f..7429272a8c26a00ed40ead45d8d5737986e4bb0a 100644
--- a/gcc/testsuite/gcc.target/arm/pr40956.c
+++ b/gcc/testsuite/gcc.target/arm/pr40956.c
@@ -1,8 +1,7 @@ 
 /* { dg-options "-Os -fpic" }  */
 /* { dg-require-effective-target fpic } */
 /* Make sure the constant "0" is loaded into register only once.  */
-/* { dg-final { scan-assembler-times "movs\[\\t \]*r., #0" 1 { target arm_thumb1 } } } */
-/* { dg-final { scan-assembler-times "mov\[\\t \]*r., #0" 1 { target { ! arm_thumb1 } } } } */
+/* { dg-final { scan-assembler-times "movs?\[\\t \]*r., #0" 1 } } */
 
 int foo(int p, int* q)
 {