[v2] libitm: sh: avoid absolute relocation in shared library (PR 86712)

Message ID 20180728130416.7730-1-slyfox@inbox.ru
State New
Headers show
Series
  • [v2] libitm: sh: avoid absolute relocation in shared library (PR 86712)
Related show

Commit Message

Fangrui Song via gcc-patches July 28, 2018, 1:04 p.m.
From: Sergei Trofimovich <slyfox@gentoo.org>


Cc: Andreas Schwab <schwab@linux-m68k.org>
Cc: Torvald Riegel <triegel@redhat.com>
Cc: Alexandre Oliva <aoliva@redhat.com>
Cc: Oleg Endo <olegendo@gcc.gnu.org>
Cc: Kaz Kojima <kkojima@gcc.gnu.org>
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

---
 libitm/config/sh/sjlj.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.18.0

Comments

Jeff Law Aug. 3, 2018, 8:54 p.m. | #1
On 07/28/2018 07:04 AM, slyfox.inbox.ru via gcc-patches wrote:
> From: Sergei Trofimovich <slyfox@gentoo.org>

> 

> Cc: Andreas Schwab <schwab@linux-m68k.org>

> Cc: Torvald Riegel <triegel@redhat.com>

> Cc: Alexandre Oliva <aoliva@redhat.com>

> Cc: Oleg Endo <olegendo@gcc.gnu.org>

> Cc: Kaz Kojima <kkojima@gcc.gnu.org>

> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

> ---

>  libitm/config/sh/sjlj.S | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/libitm/config/sh/sjlj.S b/libitm/config/sh/sjlj.S

> index 043f36749be..f265ab8f898 100644

> --- a/libitm/config/sh/sjlj.S

> +++ b/libitm/config/sh/sjlj.S

> @@ -53,7 +53,7 @@ _ITM_beginTransaction:

>  #else

>  	cfi_def_cfa_offset (4*10)

>  #endif

> -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__

> +#if !defined __PIC__

>  	mov.l	.Lbegin, r1

>  	jsr	@r1

>  	 mov	r15, r5

> @@ -78,7 +78,7 @@ _ITM_beginTransaction:

>  

>  	.align  2

>  .Lbegin:

> -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__

> +#if !defined __PIC__

>  	.long	GTM_begin_transaction

>  #else

>  	.long	GTM_begin_transaction@PCREL-(.Lbegin0-.)

> 

THanks.  I installed this version.

jeff
Oleg Endo Aug. 4, 2018, 9 a.m. | #2
On Fri, 2018-08-03 at 14:54 -0600, Jeff Law wrote:
> On 07/28/2018 07:04 AM, slyfox.inbox.ru via gcc-patches wrote:

> > 

> > From: Sergei Trofimovich <slyfox@gentoo.org>

> > 

> > Cc: Andreas Schwab <schwab@linux-m68k.org>

> > Cc: Torvald Riegel <triegel@redhat.com>

> > Cc: Alexandre Oliva <aoliva@redhat.com>

> > Cc: Oleg Endo <olegendo@gcc.gnu.org>

> > Cc: Kaz Kojima <kkojima@gcc.gnu.org>

> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

> > ---

> >  libitm/config/sh/sjlj.S | 4 ++--

> >  1 file changed, 2 insertions(+), 2 deletions(-)

> > 

> > diff --git a/libitm/config/sh/sjlj.S b/libitm/config/sh/sjlj.S

> > index 043f36749be..f265ab8f898 100644

> > --- a/libitm/config/sh/sjlj.S

> > +++ b/libitm/config/sh/sjlj.S

> > @@ -53,7 +53,7 @@ _ITM_beginTransaction:

> >  #else

> >  	cfi_def_cfa_offset (4*10)

> >  #endif

> > -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__

> > +#if !defined __PIC__

> >  	mov.l	.Lbegin, r1

> >  	jsr	@r1

> >  	 mov	r15, r5

> > @@ -78,7 +78,7 @@ _ITM_beginTransaction:

> >  

> >  	.align  2

> >  .Lbegin:

> > -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__

> > +#if !defined __PIC__

> >  	.long	GTM_begin_transaction

> >  #else

> >  	.long	GTM_begin_transaction@PCREL-(.Lbegin0-.)

> > 

> THanks.  I installed this version.

> 


Thanks Jeff.
If there are no objections, I'll backport it to the 7 and 8 branches.

Cheers,
Oleg
Oleg Endo Sept. 28, 2019, 9:13 a.m. | #3
On Sat, 2018-08-04 at 18:00 +0900, Oleg Endo wrote:
> On Fri, 2018-08-03 at 14:54 -0600, Jeff Law wrote:

> > On 07/28/2018 07:04 AM, slyfox.inbox.ru via gcc-patches wrote:

> > > 

> > > From: Sergei Trofimovich <slyfox@gentoo.org>

> > > 

> > > Cc: Andreas Schwab <schwab@linux-m68k.org>

> > > Cc: Torvald Riegel <triegel@redhat.com>

> > > Cc: Alexandre Oliva <aoliva@redhat.com>

> > > Cc: Oleg Endo <olegendo@gcc.gnu.org>

> > > Cc: Kaz Kojima <kkojima@gcc.gnu.org>

> > > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

> > > ---

> > >  libitm/config/sh/sjlj.S | 4 ++--

> > >  1 file changed, 2 insertions(+), 2 deletions(-)

> > > 

> > > diff --git a/libitm/config/sh/sjlj.S b/libitm/config/sh/sjlj.S

> > > index 043f36749be..f265ab8f898 100644

> > > --- a/libitm/config/sh/sjlj.S

> > > +++ b/libitm/config/sh/sjlj.S

> > > @@ -53,7 +53,7 @@ _ITM_beginTransaction:

> > >  #else

> > >  	cfi_def_cfa_offset (4*10)

> > >  #endif

> > > -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__

> > > +#if !defined __PIC__

> > >  	mov.l	.Lbegin, r1

> > >  	jsr	@r1

> > >  	 mov	r15, r5

> > > @@ -78,7 +78,7 @@ _ITM_beginTransaction:

> > >  

> > >  	.align  2

> > >  .Lbegin:

> > > -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__

> > > +#if !defined __PIC__

> > >  	.long	GTM_begin_transaction

> > >  #else

> > >  	.long	GTM_begin_transaction@PCREL-(.Lbegin0-.)

> > > 

> > 

> > THanks.  I installed this version.

> > 

> 

> Thanks Jeff.

> If there are no objections, I'll backport it to the 7 and 8 branches.

> 

> Cheers,

> Oleg



Finally .... committed to GCC 8 as r276246 and to GCC 7 as r276247.

Cheers,
Oleg

Patch

diff --git a/libitm/config/sh/sjlj.S b/libitm/config/sh/sjlj.S
index 043f36749be..f265ab8f898 100644
--- a/libitm/config/sh/sjlj.S
+++ b/libitm/config/sh/sjlj.S
@@ -53,7 +53,7 @@  _ITM_beginTransaction:
 #else
 	cfi_def_cfa_offset (4*10)
 #endif
-#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__
+#if !defined __PIC__
 	mov.l	.Lbegin, r1
 	jsr	@r1
 	 mov	r15, r5
@@ -78,7 +78,7 @@  _ITM_beginTransaction:
 
 	.align  2
 .Lbegin:
-#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__
+#if !defined __PIC__
 	.long	GTM_begin_transaction
 #else
 	.long	GTM_begin_transaction@PCREL-(.Lbegin0-.)