Remove -Wabi from libstdc++ build options

Message ID AM5PR0701MB26578E72403645BCC2CDD098E44D0@AM5PR0701MB2657.eurprd07.prod.outlook.com
State New
Headers show
Series
  • Remove -Wabi from libstdc++ build options
Related show

Commit Message

Bernd Edlinger June 30, 2018, 8:48 p.m.
Hi,

the -Wabi option prints a warning as follows:

cc1plus: warning: -Wabi won't warn about anything [-Wabi]
cc1plus: note: -Wabi warns about differences from the most up-to-date 
ABI, which is also used by default
cc1plus: note: use e.g. -Wabi=11 to warn about changes from GCC 7

This happens many times while building libstdc++, and as the warning
explains, it is good for nothing, so this patch removes it.


Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
Is it OK for trunk?


Thanks
Bernd.

Comments

Jonathan Wakely July 2, 2018, 5:03 p.m. | #1
On 30/06/18 20:48 +0000, Bernd Edlinger wrote:
>Hi,

>

>the -Wabi option prints a warning as follows:

>

>cc1plus: warning: -Wabi won't warn about anything [-Wabi]

>cc1plus: note: -Wabi warns about differences from the most up-to-date

>ABI, which is also used by default

>cc1plus: note: use e.g. -Wabi=11 to warn about changes from GCC 7

>

>This happens many times while building libstdc++, and as the warning

>explains, it is good for nothing, so this patch removes it.

>

>

>Bootstrapped and reg-tested on x86_64-pc-linux-gnu.

>Is it OK for trunk?


No, I don't think we want to simply remove it.

Maybe https://gcc.gnu.org/ml/gcc/2018-06/msg00276.html instead?

Patch

2018-06-30  Bernd Edlinger  <bernd.edlinger@hotmail.de>

	* acinclude.m4 (WARN_FLAGS): Remove -Wabi.
	* configure: Regenerated.

Index: libstdc++-v3/acinclude.m4
===================================================================
--- libstdc++-v3/acinclude.m4	(revision 262271)
+++ libstdc++-v3/acinclude.m4	(working copy)
@@ -733,7 +733,7 @@ 
   # OPTIMIZE_CXXFLAGS = -O3 -fstrict-aliasing -fvtable-gc
   AC_SUBST(OPTIMIZE_CXXFLAGS)
 
-  WARN_FLAGS='-Wall -Wextra -Wwrite-strings -Wcast-qual -Wabi'
+  WARN_FLAGS='-Wall -Wextra -Wwrite-strings -Wcast-qual'
   AC_SUBST(WARN_FLAGS)
 ])
 
Index: libstdc++-v3/configure
===================================================================
--- libstdc++-v3/configure	(revision 262271)
+++ libstdc++-v3/configure	(working copy)
@@ -81846,7 +81846,7 @@ 
   # OPTIMIZE_CXXFLAGS = -O3 -fstrict-aliasing -fvtable-gc
 
 
-  WARN_FLAGS='-Wall -Wextra -Wwrite-strings -Wcast-qual -Wabi'
+  WARN_FLAGS='-Wall -Wextra -Wwrite-strings -Wcast-qual'