[committed] Remove -m8byte-align as a standard multilib on v8 port

Message ID 98fd0d37-0480-023e-af6a-cc10bea7f45a@redhat.com
State New
Headers show
Series
  • [committed] Remove -m8byte-align as a standard multilib on v8 port
Related show

Commit Message

Jeff Law June 27, 2018, 2:28 p.m.
The v850 port has an option to increase alignment of objects.  However,
from my testing it looks fundamentally broken.  I suspect some kind of
dynamic stack/frame realignment is necessary for this to work properly.

As it stands using -m8byte-align can result in corrupted stack frames.

I'm leaving the option in the v8 port, but removing it from the standard
set of multilibs to be built.

Installing on the trunk,

Jeff
commit 0ae463d575053c83d2bfba3656a58a406787822d
Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Jun 27 14:27:44 2018 +0000

            * config/v850/t-v850 (MULTILIB_OPTIONS): Remove 8byte-align.
            (MULTILIB_DIRNAMES): Similarly.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@262185 138bc75d-0d04-0410-961f-82ee72b054a4

Patch

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index b9be9d55325..2d0fd08cb49 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-06-27  Jeff Law  <law@redhat.com>
+
+	* config/v850/t-v850 (MULTILIB_OPTIONS): Remove 8byte-align.
+	(MULTILIB_DIRNAMES): Similarly.
+
 2018-06-27  Eric Botcazou  <ebotcazou@adacore.com>
 
 	* gimple.h (gimple_return_retbnd): Delete.
diff --git a/gcc/config/v850/t-v850 b/gcc/config/v850/t-v850
index a7af1be3a19..984993a4fdf 100644
--- a/gcc/config/v850/t-v850
+++ b/gcc/config/v850/t-v850
@@ -17,8 +17,8 @@ 
 # <http://www.gnu.org/licenses/>.
 
 # Create target-specific versions of the libraries
-MULTILIB_OPTIONS  = m8byte-align mgcc-abi msoft-float
-MULTILIB_DIRNAMES =  8byte        gcc-abi  soft-float
+MULTILIB_OPTIONS  = mgcc-abi msoft-float
+MULTILIB_DIRNAMES =  gcc-abi  soft-float
 
 MULTILIB_OPTIONS  += mv850e3v5
 MULTILIB_DIRNAMES +=  v850e3v5