[ob/pushed] Fix macOS build, missing override

Message ID 20180524123103.2060-1-palves@redhat.com
State New
Headers show
Series
  • [ob/pushed] Fix macOS build, missing override
Related show

Commit Message

Pedro Alves May 24, 2018, 12:31 p.m.
Fixes:

In file included from ../../src/gdb/darwin-nat.c:63:0:
../../src/gdb/darwin-nat.h:28:8: error: 'virtual void darwin_nat_target::create_inferior(const char*, const string&, char**, int)' can be marked override [-Werror=suggest-override]
   void create_inferior (const char *exec_file,
        ^

gdb/ChangeLog:
2018-05-24  Pedro Alves  <palves@redhat.com>

	* darwin-nat.h (darwin_nat_target::create_inferior): Mark with
	override.
---
 gdb/ChangeLog    | 5 +++++
 gdb/darwin-nat.h | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.14.3

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8c9860380f..d700d6cdf2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-05-24  Pedro Alves  <palves@redhat.com>
+
+	* darwin-nat.h (darwin_nat_target::create_inferior): Mark with
+	override.
+
 2018-05-23  Tom Tromey  <tom@tromey.com>
 
 	* complaints.c (struct complaints): Remove.
diff --git a/gdb/darwin-nat.h b/gdb/darwin-nat.h
index 9d45bdabe8..5965df08ab 100644
--- a/gdb/darwin-nat.h
+++ b/gdb/darwin-nat.h
@@ -27,7 +27,7 @@  class darwin_nat_target : public inf_child_target
 {
   void create_inferior (const char *exec_file,
 			const std::string &allargs,
-			char **env, int from_tty);
+			char **env, int from_tty) override;
 
   void attach (const char *, int) override;