gdb/testsuite: link some dwarf2 tests with nopie

Message ID 20200805025712.1485000-1-simon.marchi@polymtl.ca
State New
Headers show
Series
  • gdb/testsuite: link some dwarf2 tests with nopie
Related show

Commit Message

Eli Zaretskii via Gdb-patches Aug. 5, 2020, 2:57 a.m.
I noticed some gdb.dwarf2 tests not running on my machine because of
this:

    Running /home/simark/src/binutils-gdb/gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp ...
    gdb compile failed, /usr/bin/ld: /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.dwarf2/dw2-single-line-discriminators/dw2-single-line-discriminators0.o: relocation R_X86_64_32S against
     symbol `x' can not be used when making a PIE object; recompile with -fPIE
    collect2: error: ld returned 1 exit status

We get this when the target toolchain produces position-independent
executables by default.  These tests are built from some assembly which
produces some relocations incompatible with position-independent
executables.

Add `nopie` to the compilation flags of these tests to force the
toolchain to produce non-position-independent executables.  With this,
the changed tests run successfully on my machine.

gdb/ChangeLog:

	* gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,
	gdb.dwarf2/dw2-dup-frame.exp, gdb.dwarf2/dw2-reg-undefined.exp,
	gdb.dwarf2/dw2-single-line-discriminators.exp,
	dw2-undefined-ret-addr.exp: Pass nopie to compilation options.

Change-Id: Ie06c946f8e56a6030be247d1c57f416fa8b67e4c
---
 gdb/testsuite/gdb.dwarf2/clztest.exp                        | 3 ++-
 gdb/testsuite/gdb.dwarf2/dw2-common-block.exp               | 2 +-
 gdb/testsuite/gdb.dwarf2/dw2-dup-frame.exp                  | 2 +-
 gdb/testsuite/gdb.dwarf2/dw2-reg-undefined.exp              | 2 +-
 gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp | 2 +-
 gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp         | 2 +-
 6 files changed, 7 insertions(+), 6 deletions(-)

-- 
2.28.0

Comments

Tom Tromey Aug. 5, 2020, 3:16 p.m. | #1
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:


Simon> gdb/ChangeLog:

Simon> 	* gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,
Simon> 	gdb.dwarf2/dw2-dup-frame.exp, gdb.dwarf2/dw2-reg-undefined.exp,
Simon> 	gdb.dwarf2/dw2-single-line-discriminators.exp,
Simon> 	dw2-undefined-ret-addr.exp: Pass nopie to compilation options.

Looks good, thank you.

Tom
Eli Zaretskii via Gdb-patches Aug. 5, 2020, 9:38 p.m. | #2
On 2020-08-05 11:16 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

> 

> Simon> gdb/ChangeLog:

> 

> Simon> 	* gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,

> Simon> 	gdb.dwarf2/dw2-dup-frame.exp, gdb.dwarf2/dw2-reg-undefined.exp,

> Simon> 	gdb.dwarf2/dw2-single-line-discriminators.exp,

> Simon> 	dw2-undefined-ret-addr.exp: Pass nopie to compilation options.

> 

> Looks good, thank you.

> 

> Tom

> 


Thanks, I pushed it.

Simon

Patch

diff --git a/gdb/testsuite/gdb.dwarf2/clztest.exp b/gdb/testsuite/gdb.dwarf2/clztest.exp
index b83b4a94e92e..95c326660f52 100644
--- a/gdb/testsuite/gdb.dwarf2/clztest.exp
+++ b/gdb/testsuite/gdb.dwarf2/clztest.exp
@@ -28,7 +28,8 @@  if {![istarget x86_64-*] || ![is_lp64_target]} {
     return 0
 }
 
-if { [prepare_for_testing "failed to prepare" "${test}" ${test}.S {nodebug additional_flags=-nostdlib}] } {
+if { [prepare_for_testing "failed to prepare" "${test}" ${test}.S \
+      {nodebug nopie additional_flags=-nostdlib}] } {
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-common-block.exp b/gdb/testsuite/gdb.dwarf2/dw2-common-block.exp
index 9bcf06b17f9d..6a10ced6cacd 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-common-block.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-common-block.exp
@@ -33,7 +33,7 @@  if {[skip_fortran_tests]} {
 standard_testfile .S
 
 if { [prepare_for_testing "failed to prepare" "${testfile}" $srcfile \
-	  {nodebug f90}] } {
+      {nodebug nopie f90}] } {
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-dup-frame.exp b/gdb/testsuite/gdb.dwarf2/dw2-dup-frame.exp
index 0c2c88e9c711..b6151084f208 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-dup-frame.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-dup-frame.exp
@@ -26,7 +26,7 @@  if {![istarget "x86_64-*-*"] || ![is_lp64_target]} {
 
 standard_testfile .S
 
-if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug}] } {
+if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug nopie}] } {
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-reg-undefined.exp b/gdb/testsuite/gdb.dwarf2/dw2-reg-undefined.exp
index 564ca91ab9bf..29564face30b 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-reg-undefined.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-reg-undefined.exp
@@ -26,7 +26,7 @@  if {![istarget "x86_64-*-*"] || ![is_lp64_target]} {
 
 standard_testfile .S
 
-if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug}] } {
+if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug nopie}] } {
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp b/gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp
index 4ca258a3f143..9803ef829a84 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp
@@ -31,7 +31,7 @@  if {![istarget x86_64-*] || ![is_lp64_target]} {
 standard_testfile .S
 set csrcfile ${testfile}.c
 
-if { [prepare_for_testing "failed to prepare" "${testfile}" $srcfile {nodebug}] } {
+if { [prepare_for_testing "failed to prepare" "${testfile}" $srcfile {nodebug nopie}] } {
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp b/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp
index e78d7112bed4..668ecfc9ab7f 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp
@@ -26,7 +26,7 @@  if {![istarget x86_64-*] || ![is_lp64_target]} {
     return 0
 }
 
-if {[prepare_for_testing "failed to prepare" "$testfile" $srcfile {nodebug}]} {
+if {[prepare_for_testing "failed to prepare" "$testfile" $srcfile {nodebug nopie}]} {
     return -1
 }