[1/4] sunrpc: Turn clnt_sperrno into a libc_hidden_nolink_sunrpc symbol

Message ID c1f248c70bedb183de214a99f3158abafb1fbec0.1594062056.git.fweimer@redhat.com
State New
Headers show
Series
  • sunrpc symbol cleanups
Related show

Commit Message

Alejandro Colomar via Libc-alpha July 6, 2020, 7:03 p.m.
Before this change, the function had a default symbol version even
without --enable-obsolete-rpc.
---
 sunrpc/clnt_perr.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.25.4

Comments

Alejandro Colomar via Libc-alpha July 6, 2020, 8:33 p.m. | #1
On Mon, Jul 6, 2020 at 12:05 PM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>

> Before this change, the function had a default symbol version even

> without --enable-obsolete-rpc.

> ---

>  sunrpc/clnt_perr.c | 4 ++++

>  1 file changed, 4 insertions(+)

>

> diff --git a/sunrpc/clnt_perr.c b/sunrpc/clnt_perr.c

> index dd5b10688e..67499fd03f 100644

> --- a/sunrpc/clnt_perr.c

> +++ b/sunrpc/clnt_perr.c

> @@ -257,7 +257,11 @@ clnt_sperrno (enum clnt_stat stat)

>      }

>    return _("RPC: (unknown error code)");

>  }

> +#ifdef EXPORT_RPC_SYMBOLS

>  libc_hidden_def (clnt_sperrno)

> +#else

> +libc_hidden_nolink_sunrpc (clnt_sperrno, GLIBC_2_0)

> +#endif

>

>  void

>  clnt_perrno (enum clnt_stat num)

> --

> 2.25.4

>


LGTM.

Thanks.


-- 
H.J.

Patch

diff --git a/sunrpc/clnt_perr.c b/sunrpc/clnt_perr.c
index dd5b10688e..67499fd03f 100644
--- a/sunrpc/clnt_perr.c
+++ b/sunrpc/clnt_perr.c
@@ -257,7 +257,11 @@  clnt_sperrno (enum clnt_stat stat)
     }
   return _("RPC: (unknown error code)");
 }
+#ifdef EXPORT_RPC_SYMBOLS
 libc_hidden_def (clnt_sperrno)
+#else
+libc_hidden_nolink_sunrpc (clnt_sperrno, GLIBC_2_0)
+#endif
 
 void
 clnt_perrno (enum clnt_stat num)