[hurd,commited] tst-cancel4-common.c: fix calling socketpair

Message ID 20200626215240.3892435-1-samuel.thibault@ens-lyon.org
State New
Headers show
Series
  • [hurd,commited] tst-cancel4-common.c: fix calling socketpair
Related show

Commit Message

Samuel Thibault June 26, 2020, 9:52 p.m.
PF_UNIX was actually never intended to be passed as protocol parameter to
socket() calls: it is a protocol family, not a protocol.  It happens that
Linux introduced accepting it during its 2.0 development, but it shouldn't.
OpenBSD kernels accept it as well, but FreeBSD and NetBSD rightfully do not.
GNU/Hurd does not either.

* nptl/tst-cancel4-common.c (do_test): Pass 0 instead of PF_UNIX as
protocol.
---
 nptl/tst-cancel4-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.27.0

Patch

diff --git a/nptl/tst-cancel4-common.c b/nptl/tst-cancel4-common.c
index f2026b81f4..9a6924c1c6 100644
--- a/nptl/tst-cancel4-common.c
+++ b/nptl/tst-cancel4-common.c
@@ -20,7 +20,7 @@ 
 static int
 do_test (void)
 {
-  if (socketpair (AF_UNIX, SOCK_STREAM, PF_UNIX, fds) != 0)
+  if (socketpair (AF_UNIX, SOCK_STREAM, 0, fds) != 0)
     {
       perror ("socketpair");
       exit (1);