x96: Remove PTA_CLWB from PTA_ICELAKE_CLIENT

Message ID 20200624162223.361929-1-hjl.tools@gmail.com
State New
Headers show
Series
  • x96: Remove PTA_CLWB from PTA_ICELAKE_CLIENT
Related show

Commit Message

Christophe Lyon via Gcc-patches June 24, 2020, 4:22 p.m.
CLWB isn't supported on Ice Lake client.  But Ice Lake server and Tiger
Lake support it.  Move PTA_CLWB to PTA_ICELAKE_SERVER and PTA_TIGERLAKE.

	PR target/95874
	* config/i386/i386.h (PTA_ICELAKE_CLIENT): Remove PTA_CLWB.
	(PTA_ICELAKE_SERVER): Add PTA_CLWB.
	(PTA_TIGERLAKE): Add PTA_CLWB.
---
 gcc/config/i386/i386.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.26.2

Comments

Christophe Lyon via Gcc-patches June 25, 2020, 8:21 a.m. | #1
On Wed, Jun 24, 2020 at 6:22 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>

> CLWB isn't supported on Ice Lake client.  But Ice Lake server and Tiger

> Lake support it.  Move PTA_CLWB to PTA_ICELAKE_SERVER and PTA_TIGERLAKE.

>

>         PR target/95874

>         * config/i386/i386.h (PTA_ICELAKE_CLIENT): Remove PTA_CLWB.

>         (PTA_ICELAKE_SERVER): Add PTA_CLWB.

>         (PTA_TIGERLAKE): Add PTA_CLWB.


OK, also for backports.

Thanks,
Uros.

> ---

>  gcc/config/i386/i386.h | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

>

> diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h

> index e1775ff0b5d..d6b57562a53 100644

> --- a/gcc/config/i386/i386.h

> +++ b/gcc/config/i386/i386.h

> @@ -2475,11 +2475,11 @@ const wide_int_bitmask PTA_CANNONLAKE = PTA_SKYLAKE | PTA_AVX512F

>    | PTA_AVX512VBMI | PTA_AVX512IFMA | PTA_SHA;

>  const wide_int_bitmask PTA_ICELAKE_CLIENT = PTA_CANNONLAKE | PTA_AVX512VNNI

>    | PTA_GFNI | PTA_VAES | PTA_AVX512VBMI2 | PTA_VPCLMULQDQ | PTA_AVX512BITALG

> -  | PTA_RDPID | PTA_CLWB | PTA_AVX512VPOPCNTDQ;

> +  | PTA_RDPID | PTA_AVX512VPOPCNTDQ;

>  const wide_int_bitmask PTA_ICELAKE_SERVER = PTA_ICELAKE_CLIENT | PTA_PCONFIG

> -  | PTA_WBNOINVD;

> +  | PTA_WBNOINVD | PTA_CLWB;

>  const wide_int_bitmask PTA_TIGERLAKE = PTA_ICELAKE_CLIENT | PTA_MOVDIRI

> -  | PTA_MOVDIR64B | PTA_AVX512VP2INTERSECT;

> +  | PTA_MOVDIR64B | PTA_CLWB | PTA_AVX512VP2INTERSECT;

>  const wide_int_bitmask PTA_KNL = PTA_BROADWELL | PTA_AVX512PF | PTA_AVX512ER

>    | PTA_AVX512F | PTA_AVX512CD;

>  const wide_int_bitmask PTA_BONNELL = PTA_CORE2 | PTA_MOVBE;

> --

> 2.26.2

>

Patch

diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h
index e1775ff0b5d..d6b57562a53 100644
--- a/gcc/config/i386/i386.h
+++ b/gcc/config/i386/i386.h
@@ -2475,11 +2475,11 @@  const wide_int_bitmask PTA_CANNONLAKE = PTA_SKYLAKE | PTA_AVX512F
   | PTA_AVX512VBMI | PTA_AVX512IFMA | PTA_SHA;
 const wide_int_bitmask PTA_ICELAKE_CLIENT = PTA_CANNONLAKE | PTA_AVX512VNNI
   | PTA_GFNI | PTA_VAES | PTA_AVX512VBMI2 | PTA_VPCLMULQDQ | PTA_AVX512BITALG
-  | PTA_RDPID | PTA_CLWB | PTA_AVX512VPOPCNTDQ;
+  | PTA_RDPID | PTA_AVX512VPOPCNTDQ;
 const wide_int_bitmask PTA_ICELAKE_SERVER = PTA_ICELAKE_CLIENT | PTA_PCONFIG
-  | PTA_WBNOINVD;
+  | PTA_WBNOINVD | PTA_CLWB;
 const wide_int_bitmask PTA_TIGERLAKE = PTA_ICELAKE_CLIENT | PTA_MOVDIRI
-  | PTA_MOVDIR64B | PTA_AVX512VP2INTERSECT;
+  | PTA_MOVDIR64B | PTA_CLWB | PTA_AVX512VP2INTERSECT;
 const wide_int_bitmask PTA_KNL = PTA_BROADWELL | PTA_AVX512PF | PTA_AVX512ER
   | PTA_AVX512F | PTA_AVX512CD;
 const wide_int_bitmask PTA_BONNELL = PTA_CORE2 | PTA_MOVBE;