ecoff testsuite fixes

Message ID 20200620124808.GF21885@bubble.grove.modra.org
State New
Headers show
Series
  • ecoff testsuite fixes
Related show

Commit Message

David Faust via Binutils June 20, 2020, 12:48 p.m.
The aim of this change is to remove a whole lot of "assembly failed"
errors for ecoff targets.

	* testsuite/ld-alpha/alpha.exp: Exclude *ecoff targets.
	* testsuite/ld-elf/binutils.exp: Likewise.
	* testsuite/ld-elf/tls.exp: Likewise.
	* testsuite/ld-elf/tls_common.exp: Likewise.
	* testsuite/ld-scripts/phdrs2.exp: Likewise.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/ld/testsuite/ld-alpha/alpha.exp b/ld/testsuite/ld-alpha/alpha.exp
index f4a395bed4..084f7f9960 100644
--- a/ld/testsuite/ld-alpha/alpha.exp
+++ b/ld/testsuite/ld-alpha/alpha.exp
@@ -22,8 +22,8 @@ 
 # Test Alpha ELF linking; all types of relocs.  This tests the
 # assembler and tools like objdump as well as the linker.
 
-if { !([istarget "alpha*-*-elf*"]
-       || [istarget "alpha*-*-linux*"]) } {
+if { !([istarget alpha*-*-elf*]
+       || ([istarget alpha*-*-linux*] && ![istarget *ecoff])) } {
     return
 }
 
diff --git a/ld/testsuite/ld-elf/binutils.exp b/ld/testsuite/ld-elf/binutils.exp
index ecaecdd05b..fc54c9869f 100644
--- a/ld/testsuite/ld-elf/binutils.exp
+++ b/ld/testsuite/ld-elf/binutils.exp
@@ -23,10 +23,10 @@ 
 
 # Make sure that binutils can correctly handle ld output in ELF.
 
-if { ![istarget *-*-linux*]
-     && ![istarget arm*-*-uclinuxfdpiceabi]
-     && ![istarget *-*-nacl*]
-     && ![istarget *-*-gnu*]} {
+if { !([istarget *-*-linux*]
+       || [istarget arm*-*-uclinuxfdpiceabi]
+       || [istarget *-*-nacl*]
+       || [istarget *-*-gnu*]) || [istarget *ecoff] } then {
     return
 }
 
diff --git a/ld/testsuite/ld-elf/tls.exp b/ld/testsuite/ld-elf/tls.exp
index 15c382fcb4..8afbb9f129 100644
--- a/ld/testsuite/ld-elf/tls.exp
+++ b/ld/testsuite/ld-elf/tls.exp
@@ -21,10 +21,10 @@ 
 
 # Make sure that binutils can correctly handle TLS.
 
-if { ![istarget *-*-linux*]
-     && ![istarget arm*-*-uclinuxfdpiceabi]
-     && ![istarget *-*-nacl*]
-     && ![istarget *-*-gnu*] } {
+if { !([istarget *-*-linux*]
+       || [istarget arm*-*-uclinuxfdpiceabi]
+       || [istarget *-*-nacl*]
+       || [istarget *-*-gnu*]) || [istarget *ecoff] } then {
     return
 }
 
diff --git a/ld/testsuite/ld-elf/tls_common.exp b/ld/testsuite/ld-elf/tls_common.exp
index 3e14ccfc21..2b6532550f 100644
--- a/ld/testsuite/ld-elf/tls_common.exp
+++ b/ld/testsuite/ld-elf/tls_common.exp
@@ -23,10 +23,10 @@ 
 
 # Make sure that binutils can correctly handle ld output in ELF.
 
-if { ![istarget *-*-linux*]
-     && ![istarget arm*-*-uclinuxfdpiceabi]
-     && ![istarget *-*-nacl*]
-     && ![istarget *-*-gnu*] } {
+if { !([istarget *-*-linux*]
+       || [istarget arm*-*-uclinuxfdpiceabi]
+       || [istarget *-*-nacl*]
+       || [istarget *-*-gnu*]) || [istarget *ecoff] } then {
     return
 }
 
diff --git a/ld/testsuite/ld-scripts/phdrs2.exp b/ld/testsuite/ld-scripts/phdrs2.exp
index d781c6dafb..2fae24fed5 100644
--- a/ld/testsuite/ld-scripts/phdrs2.exp
+++ b/ld/testsuite/ld-scripts/phdrs2.exp
@@ -19,17 +19,17 @@ 
 # MA 02110-1301, USA.
 
 # PHDRS2 is only meaningful for ELF.
-if {    ![istarget *-*-sysv4*] \
-     && ![istarget *-*-unixware*] \
-     && ![istarget *-*-elf*] \
-     && ![istarget *-*-eabi*] \
-     && ![istarget hppa*64*-*-hpux*] \
-     && ![istarget *-*-linux*] \
-     && ![istarget arm*-*-uclinuxfdpiceabi] \
-     && ![istarget *-*-gnu*] \
-     && ![istarget *-*-irix5*] \
-     && ![istarget *-*-irix6*] \
-     && ![istarget *-*-solaris2*] } {
+if { !([istarget *-*-sysv4*]
+       || [istarget *-*-unixware*]
+       || [istarget *-*-elf*]
+       || [istarget *-*-eabi*]
+       || [istarget hppa*64*-*-hpux*]
+       || [istarget *-*-linux*]
+       || [istarget arm*-*-uclinuxfdpiceabi]
+       || [istarget *-*-gnu*]
+       || [istarget *-*-irix5*]
+       || [istarget *-*-irix6*]
+       || [istarget *-*-solaris2*]) || [istarget *ecoff] } then {
     return
 }