Unnecessary load_lib in ld testsuite

Message ID 20200615053740.GA10692@bubble.grove.modra.org
State New
Headers show
Series
  • Unnecessary load_lib in ld testsuite
Related show

Commit Message

David Faust via Binutils June 15, 2020, 5:37 a.m.
ld-lib.exp is loaded in config/defaults.exp

	* testsuite/ld-scripts/include.exp: Don't load ld-lib.exp.
	* testsuite/ld-scripts/phdrs3.exp: Likewise.
	* testsuite/ld-scripts/rgn-at.exp: Likewise.
	* testsuite/ld-scripts/rgn-over.exp: Likewise.
	* testsuite/ld-scripts/sort.exp: Likewise.
	* testsuite/ld-discard/discard.exp: Likewise.  Use is_elf_format.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/ld/testsuite/ld-discard/discard.exp b/ld/testsuite/ld-discard/discard.exp
index 52c7de632a..ad1ebf4208 100644
--- a/ld/testsuite/ld-discard/discard.exp
+++ b/ld/testsuite/ld-discard/discard.exp
@@ -25,17 +25,10 @@ 
 # Test for ELF here, so we don't have to qualify on ELF specifically
 # in every .d-file.
 
-if { ![istarget *-*-linux*]
-     && ![istarget *-*-gnu*]
-     && ![istarget *-*-nacl*]
-     && ![istarget hppa*64*-*-hpux*]
-     && ![istarget arm*-*-uclinuxfdpiceabi]
-     && ![istarget *-*-elf] } {
+if {  ![is_elf_format] } {
     return
 }
 
-load_lib ld-lib.exp
-
 set test_list [lsort [glob -nocomplain $srcdir/$subdir/*.d]]
 for { set i 0 } { $i < [llength $test_list] } { incr i } {
     # We need to strip the ".d", but can leave the dirname.
diff --git a/ld/testsuite/ld-scripts/include.exp b/ld/testsuite/ld-scripts/include.exp
index 39da5dfdeb..d74f30e6d7 100644
--- a/ld/testsuite/ld-scripts/include.exp
+++ b/ld/testsuite/ld-scripts/include.exp
@@ -18,8 +18,6 @@ 
 # Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
 # MA 02110-1301, USA.
 
-load_lib ld-lib.exp
-
 if [is_aout_format] {
     return
 }
diff --git a/ld/testsuite/ld-scripts/phdrs3.exp b/ld/testsuite/ld-scripts/phdrs3.exp
index 24b7bc0285..af91814fdd 100644
--- a/ld/testsuite/ld-scripts/phdrs3.exp
+++ b/ld/testsuite/ld-scripts/phdrs3.exp
@@ -24,8 +24,6 @@  if ![is_elf_format] {
     return
 }
 
-load_lib ld-lib.exp
-
 set testname "PHDRS headers"
 
 set old_ldflags $LDFLAGS
diff --git a/ld/testsuite/ld-scripts/rgn-at.exp b/ld/testsuite/ld-scripts/rgn-at.exp
index c0308a0b46..2d246bed85 100644
--- a/ld/testsuite/ld-scripts/rgn-at.exp
+++ b/ld/testsuite/ld-scripts/rgn-at.exp
@@ -22,8 +22,6 @@  if ![is_elf_format] {
     return
 }
 
-load_lib ld-lib.exp
-
 set test_list [lsort [glob -nocomplain $srcdir/$subdir/rgn-at*.d]]
 foreach test_file $test_list {
     set test_name [file rootname $test_file]
diff --git a/ld/testsuite/ld-scripts/rgn-over.exp b/ld/testsuite/ld-scripts/rgn-over.exp
index 0985d16253..d0ec26672c 100644
--- a/ld/testsuite/ld-scripts/rgn-over.exp
+++ b/ld/testsuite/ld-scripts/rgn-over.exp
@@ -22,8 +22,6 @@  if ![is_elf_format] {
     return
 }
 
-load_lib ld-lib.exp
-
 set old_ldflags $LDFLAGS
 if { [istarget spu*-*-*] } {
     set LDFLAGS "$LDFLAGS --no-overlays"
diff --git a/ld/testsuite/ld-scripts/sort.exp b/ld/testsuite/ld-scripts/sort.exp
index 0d6832ba69..a57a58aaf8 100644
--- a/ld/testsuite/ld-scripts/sort.exp
+++ b/ld/testsuite/ld-scripts/sort.exp
@@ -30,8 +30,6 @@  if [istarget "h8300-*-*"] {
   return
 }
 
-load_lib ld-lib.exp
-
 set sort_test_list [lsort [glob -nocomplain $srcdir/$subdir/sort*.d]]
 for { set i 0 } { $i < [llength $sort_test_list] } { incr i } {
     verbose [file rootname [lindex $sort_test_list $i]]