gold: --trace: Print to stdout instead of stderr

Message ID 20200614181310.23982-1-maskray@google.com
State New
Headers show
Series
  • gold: --trace: Print to stdout instead of stderr
Related show

Commit Message

Alan Modra via Binutils June 14, 2020, 6:13 p.m.
GNU ld uses stdout.

gold/
	* object.cc (Input_objects::add_object): Use puts.
---
 gold/object.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.27.0.290.gba653c62da-goog

Comments

Alan Modra via Binutils July 20, 2020, 12:26 a.m. | #1
On 2020-06-14, Fangrui Song wrote:
>GNU ld uses stdout.

>

>gold/

>	* object.cc (Input_objects::add_object): Use puts.

>---

> gold/object.cc | 2 +-

> 1 file changed, 1 insertion(+), 1 deletion(-)

>

>diff --git a/gold/object.cc b/gold/object.cc

>index c486a2011d..799c71007f 100644

>--- a/gold/object.cc

>+++ b/gold/object.cc

>@@ -3191,7 +3191,7 @@ Input_objects::add_object(Object* obj)

> {

>   // Print the filename if the -t/--trace option is selected.

>   if (parameters->options().trace())

>-    gold_info("%s", obj->name().c_str());

>+    puts(obj->name().c_str());

>

>   if (!obj->is_dynamic())

>     this->relobj_list_.push_back(static_cast<Relobj*>(obj));

>-- 

>2.27.0.290.gba653c62da-goog

>


PING..
Alan Modra via Binutils Aug. 2, 2020, 8:56 p.m. | #2
On 2020-07-19, Fangrui Song wrote:
>On 2020-06-14, Fangrui Song wrote:

>>GNU ld uses stdout.

>>

>>gold/

>>	* object.cc (Input_objects::add_object): Use puts.

>>---

>>gold/object.cc | 2 +-

>>1 file changed, 1 insertion(+), 1 deletion(-)

>>

>>diff --git a/gold/object.cc b/gold/object.cc

>>index c486a2011d..799c71007f 100644

>>--- a/gold/object.cc

>>+++ b/gold/object.cc

>>@@ -3191,7 +3191,7 @@ Input_objects::add_object(Object* obj)

>>{

>>  // Print the filename if the -t/--trace option is selected.

>>  if (parameters->options().trace())

>>-    gold_info("%s", obj->name().c_str());

>>+    puts(obj->name().c_str());

>>

>>  if (!obj->is_dynamic())

>>    this->relobj_list_.push_back(static_cast<Relobj*>(obj));

>>-- 

>>2.27.0.290.gba653c62da-goog

>>

>

>PING..


PING^2...

Patch

diff --git a/gold/object.cc b/gold/object.cc
index c486a2011d..799c71007f 100644
--- a/gold/object.cc
+++ b/gold/object.cc
@@ -3191,7 +3191,7 @@  Input_objects::add_object(Object* obj)
 {
   // Print the filename if the -t/--trace option is selected.
   if (parameters->options().trace())
-    gold_info("%s", obj->name().c_str());
+    puts(obj->name().c_str());
 
   if (!obj->is_dynamic())
     this->relobj_list_.push_back(static_cast<Relobj*>(obj));