Fix unrecognised -mcpu target: armv7-a on arm-wrs-vxworks7 (PR95420)

Message ID 20200531224042.25801-1-ibuclaw@gdcproject.org
State New
Headers show
Series
  • Fix unrecognised -mcpu target: armv7-a on arm-wrs-vxworks7 (PR95420)
Related show

Commit Message

David Malcolm via Gcc-patches May 31, 2020, 10:40 p.m.
Hi,

In the removal of arm-wrs-vxworks, the default cpu was updated from arm8
to armv7-a, but this is not recognized as a valid -mcpu target.  There
is however generic-armv7-a, which was likely the intended cpu that
should have been used instead.

Tested by building a cross-compiler targetting arm-wrs-vxworks7, running
make all-gcc and ensuring it succeeds.

OK?  This affects release/gcc-10 branch as well, so should be
backported too.

Regards
Iain.


gcc/ChangeLog:

	PR target/95420
	* config.gcc (arm-wrs-vxworks7*): Set default cpu to generic-armv7-a.
---
 gcc/config.gcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Richard Earnshaw June 1, 2020, 4:40 p.m. | #1
On 31/05/2020 23:40, Iain Buclaw via Gcc-patches wrote:
> Hi,

> 

> In the removal of arm-wrs-vxworks, the default cpu was updated from arm8

> to armv7-a, but this is not recognized as a valid -mcpu target.  There

> is however generic-armv7-a, which was likely the intended cpu that

> should have been used instead.

> 

> Tested by building a cross-compiler targetting arm-wrs-vxworks7, running

> make all-gcc and ensuring it succeeds.

> 

> OK?  This affects release/gcc-10 branch as well, so should be

> backported too.

> 

> Regards

> Iain.

> 

> 

> gcc/ChangeLog:

> 

> 	PR target/95420

> 	* config.gcc (arm-wrs-vxworks7*): Set default cpu to generic-armv7-a.

> ---

>  gcc/config.gcc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/gcc/config.gcc b/gcc/config.gcc

> index f544932fc39..06ad813ad39 100644

> --- a/gcc/config.gcc

> +++ b/gcc/config.gcc

> @@ -1193,7 +1193,7 @@ arm-wrs-vxworks7*)

>  	tmake_file="${tmake_file} arm/t-arm arm/t-vxworks arm/t-bpabi"

>  	tm_file="elfos.h arm/elf.h arm/bpabi.h arm/aout.h ${tm_file}"

>  	tm_file="${tm_file} vx-common.h vxworks.h arm/vxworks.h"

> -	target_cpu_cname="armv7-a"

> +	target_cpu_cname="generic-armv7-a"

>  	need_64bit_hwint=yes

>  	;;

>  arm*-*-freebsd*)                # ARM FreeBSD EABI

> 


OK all.

Thanks,

R.
Olivier Hainque June 1, 2020, 5 p.m. | #2
Hello Iain,

> On 01 Jun 2020, at 00:40, Iain Buclaw <ibuclaw@gdcproject.org> wrote:

> 

> Hi,

> 

> In the removal of arm-wrs-vxworks, the default cpu was updated from arm8

> to armv7-a, but this is not recognized as a valid -mcpu target.  There

> is however generic-armv7-a, which was likely the intended cpu that

> should have been used instead.


Yes, indeed.

> Tested by building a cross-compiler targetting arm-wrs-vxworks7, running

> make all-gcc and ensuring it succeeds.

> 

> OK?


Yes, OK.

>  This affects release/gcc-10 branch as well, so should be

> backported too.


Certainly. Could you please ?

Thanks!

Olivier
David Malcolm via Gcc-patches June 2, 2020, 8:39 a.m. | #3
On 01/06/2020 19:00, Olivier Hainque wrote:
> Hello Iain,

> 

>> On 01 Jun 2020, at 00:40, Iain Buclaw <ibuclaw@gdcproject.org> wrote:

>>

>> Hi,

>>

>> In the removal of arm-wrs-vxworks, the default cpu was updated from arm8

>> to armv7-a, but this is not recognized as a valid -mcpu target.  There

>> is however generic-armv7-a, which was likely the intended cpu that

>> should have been used instead.

> 

> Yes, indeed.

> 

>> Tested by building a cross-compiler targetting arm-wrs-vxworks7, running

>> make all-gcc and ensuring it succeeds.

>>

>> OK?

> 

> Yes, OK.

> 

>>  This affects release/gcc-10 branch as well, so should be

>> backported too.

> 

> Certainly. Could you please ?

> 


Done (both master and releases/gcc-10).

Iain.
Olivier Hainque June 2, 2020, 8:56 a.m. | #4
Hello Iain,

> On 02 Jun 2020, at 10:39, Iain Buclaw <ibuclaw@gdcproject.org> wrote:

> 

> Done (both master and releases/gcc-10).


Great, thanks!

Patch

diff --git a/gcc/config.gcc b/gcc/config.gcc
index f544932fc39..06ad813ad39 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -1193,7 +1193,7 @@  arm-wrs-vxworks7*)
 	tmake_file="${tmake_file} arm/t-arm arm/t-vxworks arm/t-bpabi"
 	tm_file="elfos.h arm/elf.h arm/bpabi.h arm/aout.h ${tm_file}"
 	tm_file="${tm_file} vx-common.h vxworks.h arm/vxworks.h"
-	target_cpu_cname="armv7-a"
+	target_cpu_cname="generic-armv7-a"
 	need_64bit_hwint=yes
 	;;
 arm*-*-freebsd*)                # ARM FreeBSD EABI