gdb: change duplicate test name in gdb.base/jit-so.exp

Message ID 20200420140514.131327-1-simon.marchi@polymtl.ca
State New
Headers show
Series
  • gdb: change duplicate test name in gdb.base/jit-so.exp
Related show

Commit Message

Rogerio Alves via Gdb-patches April 20, 2020, 2:05 p.m.
When running gdb.base/jit-so.exp, we see duplicate test names:

$ grep PASS testsuite/gdb.sum | sort | uniq -c | sort -n
      ...
      2 PASS: gdb.base/jit-so.exp: one_jit_test-1: info function jit_function
      2 PASS: gdb.base/jit-so.exp: one_jit_test-2: info function jit_function

Give an explicit name to one test to avoid this.

gdb/testsuite/ChangeLog:

	* gdb.base/jit-so.exp (one_jit_test): Change test name.
---
 gdb/testsuite/gdb.base/jit-so.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.26.1

Comments

Rogerio Alves via Gdb-patches May 12, 2020, 12:11 a.m. | #1
On 2020-04-20 10:05 a.m., Simon Marchi wrote:
> When running gdb.base/jit-so.exp, we see duplicate test names:

> 

> $ grep PASS testsuite/gdb.sum | sort | uniq -c | sort -n

>       ...

>       2 PASS: gdb.base/jit-so.exp: one_jit_test-1: info function jit_function

>       2 PASS: gdb.base/jit-so.exp: one_jit_test-2: info function jit_function

> 

> Give an explicit name to one test to avoid this.

> 

> gdb/testsuite/ChangeLog:

> 

> 	* gdb.base/jit-so.exp (one_jit_test): Change test name.

> ---

>  gdb/testsuite/gdb.base/jit-so.exp | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/gdb/testsuite/gdb.base/jit-so.exp b/gdb/testsuite/gdb.base/jit-so.exp

> index 27dcdfa58e21..9183df69a03d 100644

> --- a/gdb/testsuite/gdb.base/jit-so.exp

> +++ b/gdb/testsuite/gdb.base/jit-so.exp

> @@ -110,7 +110,8 @@ proc one_jit_test {count match_str} {

>  	gdb_continue_to_breakpoint "break here 2"

>  	# All jit librares must have been unregistered

>  	gdb_test "info function jit_function" \

> -	    "All functions matching regular expression \"jit_function\":"

> +	    "All functions matching regular expression \"jit_function\":" \

> +	    "info function jit_function after unregistration"

>      }

>  }

>  

> -- 

> 2.26.1

> 


I had forgotten about this patch but remembered while reviewing the JIT test patchset.  I've
pushed it now.

Simon

Patch

diff --git a/gdb/testsuite/gdb.base/jit-so.exp b/gdb/testsuite/gdb.base/jit-so.exp
index 27dcdfa58e21..9183df69a03d 100644
--- a/gdb/testsuite/gdb.base/jit-so.exp
+++ b/gdb/testsuite/gdb.base/jit-so.exp
@@ -110,7 +110,8 @@  proc one_jit_test {count match_str} {
 	gdb_continue_to_breakpoint "break here 2"
 	# All jit librares must have been unregistered
 	gdb_test "info function jit_function" \
-	    "All functions matching regular expression \"jit_function\":"
+	    "All functions matching regular expression \"jit_function\":" \
+	    "info function jit_function after unregistration"
     }
 }