ld: Don't xfail ld-elf/warn[12] on 64-bit Solaris/SPARC

Message ID yddftdcogw8.fsf@CeBiTec.Uni-Bielefeld.DE
State New
Headers show
Series
  • ld: Don't xfail ld-elf/warn[12] on 64-bit Solaris/SPARC
Related show

Commit Message

Rainer Orth April 9, 2020, 2:47 p.m.
Two ld tests currently XPASS on 64-bit Solaris/SPARC:

XPASS: ld-elf/warn1
XPASS: ld-elf/warn2

They were xfail'ed on Solaris/SPARCv9 back in 2005

	https://sourceware.org/pipermail/binutils/2005-February/039268.html

but obviously this no longer appplies.

Fixed by removing the xfail's.

Tested on sparcv9-sun-solaris2.11 and sparc-sun-solaris2.11.

Ok for master?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2020-04-09  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* testsuite/ld-elf/warn1.d: Don't xfail on 64-bit Solaris/SPARC.
	* testsuite/ld-elf/warn2.d: Likewise.

Comments

Alan Modra via Binutils April 17, 2020, 2:26 p.m. | #1
Hi Rainer,

> Two ld tests currently XPASS on 64-bit Solaris/SPARC:

> 

> XPASS: ld-elf/warn1

> XPASS: ld-elf/warn2

> 

> They were xfail'ed on Solaris/SPARCv9 back in 2005

> 

> 	https://sourceware.org/pipermail/binutils/2005-February/039268.html

> 

> but obviously this no longer appplies.

> 

> Fixed by removing the xfail's.

> 

> Tested on sparcv9-sun-solaris2.11 and sparc-sun-solaris2.11.

> 

> Ok for master?


Approved - please apply.

Cheers
  Nick

Patch

# HG changeset patch
# Parent  c9287bd43c85b10008434f38b6ba99cd5d43c786
ld: Don't xfail ld-elf/warn[12] on 64-bit Solaris/SPARC

diff --git a/ld/testsuite/ld-elf/warn1.d b/ld/testsuite/ld-elf/warn1.d
--- a/ld/testsuite/ld-elf/warn1.d
+++ b/ld/testsuite/ld-elf/warn1.d
@@ -5,7 +5,6 @@ 
 #warning: ^[^\n]*\): warning: witty one-liner$
 #readelf: -s
 #xfail: [is_generic]
-#xfail: "sparc64-*-solaris2*" "sparcv9-*-solaris2*"
 
 # Check that warnings are generated for the .gnu.warning.SYMBOL
 # construct and that the symbol still appears as expected.
diff --git a/ld/testsuite/ld-elf/warn2.d b/ld/testsuite/ld-elf/warn2.d
--- a/ld/testsuite/ld-elf/warn2.d
+++ b/ld/testsuite/ld-elf/warn2.d
@@ -6,7 +6,6 @@ 
 #readelf: -s
 # if not using elf.em, you don't get fancy section handling
 #xfail: [uses_genelf]
-#xfail: "sparc64-*-solaris2*" "sparcv9-*-solaris2*"
 
 # Check that warnings are generated for the symbols in .gnu.warning
 # construct and that the symbol still appears as expected.