RS6000: Use .machine ppc for some CRT files

Message ID 20200407051825.12516-1-sebastian.huber@embedded-brains.de
State New
Headers show
Series
  • RS6000: Use .machine ppc for some CRT files
Related show

Commit Message

Sebastian Huber April 7, 2020, 5:18 a.m.
Since commit e154242724b084380e3221df7c08fcdbd8460674 the flag -many is
sometimes not passed to the assembler.  Use .machine ppc to prevent
errors if these files are assembled for an ISA which does not support
FPRs.

libgcc/

	* config/rs6000/crtresfpr.S: Use .machine ppc.
	* config/rs6000/crtresxfpr.S: Likewise.
	* config/rs6000/crtsavfpr.S: Likewise.
---
 libgcc/config/rs6000/crtresfpr.S  | 1 +
 libgcc/config/rs6000/crtresxfpr.S | 1 +
 libgcc/config/rs6000/crtsavfpr.S  | 1 +
 3 files changed, 3 insertions(+)

-- 
2.16.4

Comments

Sebastian Huber April 17, 2020, 5:59 a.m. | #1
Hello Segher,

would you mind having a look at this patch.
Segher Boessenkool April 24, 2020, 8:55 p.m. | #2
On Fri, Apr 17, 2020 at 07:59:02AM +0200, Sebastian Huber wrote:
> would you mind having a look at this patch.


Hi!

I see no patch?


Segher
Iain Buclaw via Gcc-patches April 24, 2020, 9:47 p.m. | #3
On 4/17/20 12:59 AM, Sebastian Huber wrote:
> Hello Segher,

> 

> would you mind having a look at this patch.

> 


His patch is here:

  https://gcc.gnu.org/pipermail/gcc-patches/2020-April/543396.html

Peter
Segher Boessenkool April 25, 2020, 12:15 a.m. | #4
On Fri, Apr 24, 2020 at 04:47:31PM -0500, Peter Bergner wrote:
> On 4/17/20 12:59 AM, Sebastian Huber wrote:

> > Hello Segher,

> > 

> > would you mind having a look at this patch.

> > 

> 

> His patch is here:

> 

>   https://gcc.gnu.org/pipermail/gcc-patches/2020-April/543396.html


(And at
https://patchwork.ozlabs.org/project/gcc/patch/20200407051825.12516-1-sebastian.huber@embedded-brains.de/
where you can see headers as well).

Ah, I wasn't Cc:ed, and I don't have a regexp for "RS6000" :-)


Segher
Segher Boessenkool April 25, 2020, 12:20 a.m. | #5
Hi!

On Tue, Apr 07, 2020 at 07:18:25AM +0200, Sebastian Huber wrote:
> Since commit e154242724b084380e3221df7c08fcdbd8460674 the flag -many is

> sometimes not passed to the assembler.  Use .machine ppc to prevent

> errors if these files are assembled for an ISA which does not support

> FPRs.

> 

> libgcc/

> 

> 	* config/rs6000/crtresfpr.S: Use .machine ppc.

> 	* config/rs6000/crtresxfpr.S: Likewise.

> 	* config/rs6000/crtsavfpr.S: Likewise.


This is fine.  Okay for trunk.  Thank you!

Also okay for backports if you want -- after letting it simmer on trunk
for a week or so.


Segher

Patch

diff --git a/libgcc/config/rs6000/crtresfpr.S b/libgcc/config/rs6000/crtresfpr.S
index 6c0d01bf9c1..99e6f086026 100644
--- a/libgcc/config/rs6000/crtresfpr.S
+++ b/libgcc/config/rs6000/crtresfpr.S
@@ -27,6 +27,7 @@ 
 
 /* Do any initializations needed for the eabi environment */
 
+	.machine ppc
 	.section ".text"
 	#include "ppc-asm.h"
 
diff --git a/libgcc/config/rs6000/crtresxfpr.S b/libgcc/config/rs6000/crtresxfpr.S
index 9f01fa5094b..9931db244f7 100644
--- a/libgcc/config/rs6000/crtresxfpr.S
+++ b/libgcc/config/rs6000/crtresxfpr.S
@@ -27,6 +27,7 @@ 
 
 /* Do any initializations needed for the eabi environment */
 
+	.machine ppc
 	.section ".text"
 	#include "ppc-asm.h"
 
diff --git a/libgcc/config/rs6000/crtsavfpr.S b/libgcc/config/rs6000/crtsavfpr.S
index fa043ddd078..dd8743ae058 100644
--- a/libgcc/config/rs6000/crtsavfpr.S
+++ b/libgcc/config/rs6000/crtsavfpr.S
@@ -27,6 +27,7 @@ 
 
 /* Do any initializations needed for the eabi environment */
 
+	.machine ppc
 	.section ".text"
 	#include "ppc-asm.h"