ld: Xfail pr20995-2 tests for Solaris

Message ID 20200327143604.89942-1-hjl.tools@gmail.com
State New
Headers show
Series
  • ld: Xfail pr20995-2 tests for Solaris
Related show

Commit Message

H.J. Lu via Binutils March 27, 2020, 2:36 p.m.
Xfail pr20995-2 tests for Solaris since Solaris doesn't support RELRO.

	PR 25732
	* testsuite/ld-elf/shared.exp: Xfail pr20995-2 tests for Solaris.
---
 ld/ChangeLog                   | 5 +++++
 ld/testsuite/ld-elf/shared.exp | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

-- 
2.25.1

Comments

H.J. Lu via Binutils March 28, 2020, 2:52 a.m. | #1
On Fri, Mar 27, 2020 at 07:36:04AM -0700, H.J. Lu via Binutils wrote:
> Xfail pr20995-2 tests for Solaris since Solaris doesn't support RELRO.

> 

> 	PR 25732

> 	* testsuite/ld-elf/shared.exp: Xfail pr20995-2 tests for Solaris.


sparc-sun-solaris2  +XPASS: Build pr20995-2.so
sparc-sun-solaris2  +XPASS: pr20995-2

-- 
Alan Modra
Australia Development Lab, IBM
H.J. Lu via Binutils March 28, 2020, 3:37 a.m. | #2
On Fri, Mar 27, 2020 at 7:52 PM Alan Modra <amodra@gmail.com> wrote:
>

> On Fri, Mar 27, 2020 at 07:36:04AM -0700, H.J. Lu via Binutils wrote:

> > Xfail pr20995-2 tests for Solaris since Solaris doesn't support RELRO.

> >

> >       PR 25732

> >       * testsuite/ld-elf/shared.exp: Xfail pr20995-2 tests for Solaris.

>

> sparc-sun-solaris2  +XPASS: Build pr20995-2.so

> sparc-sun-solaris2  +XPASS: pr20995-2

>


Since Solaris doesn't support RELRO, it is quite odd for them to pass
for sparc-sun-solaris2.  I can change it to i386-*-solaris*.

-- 
H.J.
H.J. Lu via Binutils March 28, 2020, 12:11 p.m. | #3
On Fri, Mar 27, 2020 at 8:37 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>

> On Fri, Mar 27, 2020 at 7:52 PM Alan Modra <amodra@gmail.com> wrote:

> >

> > On Fri, Mar 27, 2020 at 07:36:04AM -0700, H.J. Lu via Binutils wrote:

> > > Xfail pr20995-2 tests for Solaris since Solaris doesn't support RELRO.

> > >

> > >       PR 25732

> > >       * testsuite/ld-elf/shared.exp: Xfail pr20995-2 tests for Solaris.

> >

> > sparc-sun-solaris2  +XPASS: Build pr20995-2.so

> > sparc-sun-solaris2  +XPASS: pr20995-2

> >

>

> Since Solaris doesn't support RELRO, it is quite odd for them to pass

> for sparc-sun-solaris2.  I can change it to i386-*-solaris*.

>


This is what I checked in.

-- 
H.J.

Patch

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 752453e396..09b01b9025 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@ 
+2020-03-27  H.J. Lu  <hongjiu.lu@intel.com>
+
+	PR 25732
+	* testsuite/ld-elf/shared.exp: Xfail pr20995-2 tests for Solaris.
+
 2020-03-27  H.J. Lu  <hongjiu.lu@intel.com>
 
 	PR 25732
diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp
index b1762aff9b..e9f229838f 100644
--- a/ld/testsuite/ld-elf/shared.exp
+++ b/ld/testsuite/ld-elf/shared.exp
@@ -465,7 +465,7 @@  run_ld_link_tests [list \
 	"-shared -z relro" "" "$AFLAGS_PIC" \
 	{pr20995c.s} {{readelf {-l --wide} pr20995-2so.r}} "pr20995-2.so"] \
 ] "tic6x-*-*" "arm*-*-eabi*" "hppa*64*-*-hpux*" "aarch64*-*-elf*" \
-  "*-*-lynxos*" "arm*-*-nto*" "i?86-*-nto*" "sh*-*-nto*"
+  "*-*-lynxos*" "arm*-*-nto*" "i?86-*-nto*" "sh*-*-nto*" "*-*-solaris*"
 
 # These targets don't copy dynamic variables into .bss.
 setup_xfail "alpha-*-*" "bfin-*-*" "ia64-*-*" "xtensa-*-*"
@@ -486,7 +486,7 @@  run_ld_link_tests [list \
 	"pr20995-2" \
 	"$LFLAGS" "tmpdir/pr20995-2.so" "$AFLAGS_NONPIC" \
 	{pr20995a.s} {{readelf {-S --wide} pr20995.r}} "pr20995-2"]
-] "*-*-lynxos*" "arm*-*-nto*" "i?86-*-nto*" "sh*-*-nto*"
+] "*-*-lynxos*" "arm*-*-nto*" "i?86-*-nto*" "sh*-*-nto*" "*-*-solaris*"
 
 run_ld_link_tests [list \
     [list "Build pr22374 shared library" \