[committed] libstdc++: Change compile-only test to run

Message ID 20200310094949.GA3363827@redhat.com
State New
Headers show
Series
  • [committed] libstdc++: Change compile-only test to run
Related show

Commit Message

Jonathan Wakely March 10, 2020, 9:49 a.m.
The 24_iterators/ostream_iterator/1.cc test uses VERIFY and so is
obviously meant to have been run, not just compiled.

	* testsuite/23_containers/unordered_set/allocator/ext_ptr.cc: Add
	comment explaining multiple dg-do directives.
	* testsuite/24_iterators/ostream_iterator/1.cc: Fix do-do directive
	so test is run as well as compiled.

Tested x86_64-linux, committed to master.
commit 3654d49d0ff651b2a78401bc2430428711e7d2eb
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Mar 10 09:47:15 2020 +0000

    libstdc++: Change compile-only test to run
    
    The 24_iterators/ostream_iterator/1.cc test uses VERIFY and so is
    obviously meant to have been run, not just compiled.
    
            * testsuite/23_containers/unordered_set/allocator/ext_ptr.cc: Add
            comment explaining multiple dg-do directives.
            * testsuite/24_iterators/ostream_iterator/1.cc: Fix do-do directive
            so test is run as well as compiled.

Patch

diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/ext_ptr.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/ext_ptr.cc
index 5cbc76e0d8c..f6b908ac03e 100644
--- a/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/ext_ptr.cc
+++ b/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/ext_ptr.cc
@@ -15,6 +15,8 @@ 
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
+// This test fails to compile since C++17 (see xfail-if below) so we can only
+// do a "run" test for C++11 and C++14, and a "compile" test for C++17 and up.
 // { dg-do run { target { c++11_only || c++14_only } } }
 // { dg-do compile { target c++17 } }
 
diff --git a/libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc b/libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc
index 640ff61afa7..718dad3b684 100644
--- a/libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc
+++ b/libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc
@@ -15,7 +15,7 @@ 
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
-// { dg-do compile { target c++11 } }
+// { dg-do run { target c++11 } }
 
 #include <iterator>
 #include <sstream>