Call cleanup on bfd_check_format_matches error exit

Message ID 20200304011749.GQ5384@bubble.grove.modra.org
State New
Headers show
Series
  • Call cleanup on bfd_check_format_matches error exit
Related show

Commit Message

Alan Modra March 4, 2020, 1:17 a.m.
Another tidy of memory.

	* format.c (bfd_check_format_matches): Call cleanup on error exit.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/bfd/format.c b/bfd/format.c
index 61f26c6042..ab98486fb4 100644
--- a/bfd/format.c
+++ b/bfd/format.c
@@ -515,6 +515,8 @@  bfd_check_format_matches (bfd *abfd, bfd_format format, char ***matching)
     err_unrecog:
       bfd_set_error (bfd_error_file_not_recognized);
     err_ret:
+      if (cleanup)
+	cleanup (abfd);
       abfd->xvec = save_targ;
       abfd->format = bfd_unknown;
       if (matching_vector)
@@ -544,6 +546,8 @@  bfd_check_format_matches (bfd *abfd, bfd_format format, char ***matching)
     }
   else if (matching_vector)
     free (matching_vector);
+  if (cleanup)
+    cleanup (abfd);
   if (preserve_match.marker != NULL)
     bfd_preserve_finish (abfd, &preserve_match);
   bfd_preserve_restore (abfd, &preserve);