[committed] testsuite: Fix up gcc.target/powerpc/pr93122.c test

Message ID 20200212222701.GB17695@tucnak
State New
Headers show
Series
  • [committed] testsuite: Fix up gcc.target/powerpc/pr93122.c test
Related show

Commit Message

Jakub Jelinek Feb. 12, 2020, 10:27 p.m.
On Mon, Feb 10, 2020 at 01:45:42PM -0500, Michael Meissner wrote:
> This patch renames the PowerPC internal switch -mprefixed-addr to be

> -mprefixed.



	Jakub

Comments

Segher Boessenkool Feb. 12, 2020, 10:30 p.m. | #1
On Wed, Feb 12, 2020 at 11:27:01PM +0100, Jakub Jelinek wrote:
> On Mon, Feb 10, 2020 at 01:45:42PM -0500, Michael Meissner wrote:

> > This patch renames the PowerPC internal switch -mprefixed-addr to be

> > -mprefixed.


> This change broke the gcc.target/powerpc/pr93122.c test, so it now

> FAIL: gcc.target/powerpc/pr93122.c (test for excess errors)

> Excess errors:

> xgcc: error: unrecognized command-line option '-mprefixed-addr'; did you mean '-mprefixed'?

> 

> Fixed thusly, bootstrapped/regtested on powerpc64le-linux, committed to

> trunk as obvious.


Thanks!


Segher
Michael Meissner Feb. 12, 2020, 10:43 p.m. | #2
On Wed, Feb 12, 2020 at 11:27:01PM +0100, Jakub Jelinek wrote:
> On Mon, Feb 10, 2020 at 01:45:42PM -0500, Michael Meissner wrote:

> > This patch renames the PowerPC internal switch -mprefixed-addr to be

> > -mprefixed.

> 

> --- gcc/config/rs6000/rs6000.opt

> +++ gcc/config/rs6000/rs6000.opt

> @@ -570,8 +570,8 @@ mfuture

>  Target Report Mask(FUTURE) Var(rs6000_isa_flags)

>  Use instructions for a future architecture.

>  

> -mprefixed-addr

> -Target Undocumented Mask(PREFIXED_ADDR) Var(rs6000_isa_flags)

> +mprefixed

> +Target Report Mask(PREFIXED) Var(rs6000_isa_flags)

>  Generate (do not generate) prefixed memory instructions.

>  

>  mpcrel

> 

> This change broke the gcc.target/powerpc/pr93122.c test, so it now

> FAIL: gcc.target/powerpc/pr93122.c (test for excess errors)

> Excess errors:

> xgcc: error: unrecognized command-line option '-mprefixed-addr'; did you mean '-mprefixed'?

> 

> Fixed thusly, bootstrapped/regtested on powerpc64le-linux, committed to

> trunk as obvious.


Thanks.  I don't think that test was in the trunk when I did the the bootstrap
for the -mprefixed-addr to -mprefixed option.  I was about to send a similar
patch.

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.ibm.com, phone: +1 (978) 899-4797

Patch

--- gcc/config/rs6000/rs6000.opt
+++ gcc/config/rs6000/rs6000.opt
@@ -570,8 +570,8 @@  mfuture
 Target Report Mask(FUTURE) Var(rs6000_isa_flags)
 Use instructions for a future architecture.
 
-mprefixed-addr
-Target Undocumented Mask(PREFIXED_ADDR) Var(rs6000_isa_flags)
+mprefixed
+Target Report Mask(PREFIXED) Var(rs6000_isa_flags)
 Generate (do not generate) prefixed memory instructions.
 
 mpcrel

This change broke the gcc.target/powerpc/pr93122.c test, so it now
FAIL: gcc.target/powerpc/pr93122.c (test for excess errors)
Excess errors:
xgcc: error: unrecognized command-line option '-mprefixed-addr'; did you mean '-mprefixed'?

Fixed thusly, bootstrapped/regtested on powerpc64le-linux, committed to
trunk as obvious.

2020-02-12  Jakub Jelinek  <jakub@redhat.com>

	* gcc.target/powerpc/pr93122.c: Use -mprefixed instead of
	-mprefixed-addr in dg-options.

--- gcc/testsuite/gcc.target/powerpc/pr93122.c
+++ gcc/testsuite/gcc.target/powerpc/pr93122.c
@@ -1,6 +1,6 @@ 
 /* PR target/93122 */
 /* { dg-do compile { target lp64 } } */
-/* { dg-options "-fstack-clash-protection -mprefixed-addr -mfuture" } */
+/* { dg-options "-fstack-clash-protection -mprefixed -mfuture" } */
 
 void bar (char *);