[14/15] nptl: Remove ununsed pthread-errnos.h rule

Message ID 20200210192038.23588-14-adhemerval.zanella@linaro.org
State New
Headers show
Series
  • [01/15] powerpc: Consolidate Linux syscall definition
Related show

Commit Message

Adhemerval Zanella Feb. 10, 2020, 7:20 p.m.
---
 nptl/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.17.1

Comments

Florian Weimer Feb. 11, 2020, 11:23 a.m. | #1
* Adhemerval Zanella:

> ---

>  nptl/Makefile | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)

>

> diff --git a/nptl/Makefile b/nptl/Makefile

> index 6f210d60e3..fcdc72adfe 100644

> --- a/nptl/Makefile

> +++ b/nptl/Makefile

> @@ -327,8 +327,7 @@ test-xfail-tst-once5 = yes

>  # Files which must not be linked with libpthread.

>  tests-nolibpthread = tst-unload

>  

> -gen-as-const-headers = pthread-errnos.sym \

> -		       unwindbuf.sym \

> +gen-as-const-headers = unwindbuf.sym \

>  		       pthread-pi-defines.sym

>  

>  gen-py-const-headers := nptl_lock_constants.pysym


I don't think this is unused?

Thanks,
Florian
Florian Weimer Feb. 11, 2020, 11:51 a.m. | #2
* Florian Weimer:

> * Adhemerval Zanella:

>

>> ---

>>  nptl/Makefile | 3 +--

>>  1 file changed, 1 insertion(+), 2 deletions(-)

>>

>> diff --git a/nptl/Makefile b/nptl/Makefile

>> index 6f210d60e3..fcdc72adfe 100644

>> --- a/nptl/Makefile

>> +++ b/nptl/Makefile

>> @@ -327,8 +327,7 @@ test-xfail-tst-once5 = yes

>>  # Files which must not be linked with libpthread.

>>  tests-nolibpthread = tst-unload

>>  

>> -gen-as-const-headers = pthread-errnos.sym \

>> -		       unwindbuf.sym \

>> +gen-as-const-headers = unwindbuf.sym \

>>  		       pthread-pi-defines.sym

>>  

>>  gen-py-const-headers := nptl_lock_constants.pysym

>

> I don't think this is unused?


Sorry, I see the changes now.  But why doesn't this patch delete the
pthread-errnos.sym file as well?

Thanks,
Florian
Adhemerval Zanella Feb. 11, 2020, 9:01 p.m. | #3
On 11/02/2020 08:51, Florian Weimer wrote:
> * Florian Weimer:

> 

>> * Adhemerval Zanella:

>>

>>> ---

>>>  nptl/Makefile | 3 +--

>>>  1 file changed, 1 insertion(+), 2 deletions(-)

>>>

>>> diff --git a/nptl/Makefile b/nptl/Makefile

>>> index 6f210d60e3..fcdc72adfe 100644

>>> --- a/nptl/Makefile

>>> +++ b/nptl/Makefile

>>> @@ -327,8 +327,7 @@ test-xfail-tst-once5 = yes

>>>  # Files which must not be linked with libpthread.

>>>  tests-nolibpthread = tst-unload

>>>  

>>> -gen-as-const-headers = pthread-errnos.sym \

>>> -		       unwindbuf.sym \

>>> +gen-as-const-headers = unwindbuf.sym \

>>>  		       pthread-pi-defines.sym

>>>  

>>>  gen-py-const-headers := nptl_lock_constants.pysym

>>

>> I don't think this is unused?

> 

> Sorry, I see the changes now.  But why doesn't this patch delete the

> pthread-errnos.sym file as well?


I update the patch to delete it, thanks for catching it.

Patch

diff --git a/nptl/Makefile b/nptl/Makefile
index 6f210d60e3..fcdc72adfe 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -327,8 +327,7 @@  test-xfail-tst-once5 = yes
 # Files which must not be linked with libpthread.
 tests-nolibpthread = tst-unload
 
-gen-as-const-headers = pthread-errnos.sym \
-		       unwindbuf.sym \
+gen-as-const-headers = unwindbuf.sym \
 		       pthread-pi-defines.sym
 
 gen-py-const-headers := nptl_lock_constants.pysym