[26/26] microblaze: vfork is always available

Message ID b59c4d3ad6448be3db09f92c36fbe29edb1f18b1.1581279333.git.fweimer@redhat.com
State New
Headers show
Series
  • Linux cleanups enabled by built-in system call tables
Related show

Commit Message

Florian Weimer Feb. 9, 2020, 8:21 p.m.
Due to the built-in tables, __NR_vfork is always defined, so the
fork-based fallback code is never used.

(It appears that the vfork system call was wired up when the port was
contributed to the kernel.)
---
 sysdeps/unix/sysv/linux/microblaze/vfork.S | 4 ----
 1 file changed, 4 deletions(-)

-- 
2.24.1

Comments

Adhemerval Zanella Feb. 27, 2020, 11:47 p.m. | #1
On 09/02/2020 17:21, Florian Weimer wrote:
> Due to the built-in tables, __NR_vfork is always defined, so the

> fork-based fallback code is never used.

> 

> (It appears that the vfork system call was wired up when the port was

> contributed to the kernel.)


LGTM, thanks. 

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>


> ---

>  sysdeps/unix/sysv/linux/microblaze/vfork.S | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/sysdeps/unix/sysv/linux/microblaze/vfork.S b/sysdeps/unix/sysv/linux/microblaze/vfork.S

> index 7bff659ff3..913aa06e2e 100644

> --- a/sysdeps/unix/sysv/linux/microblaze/vfork.S

> +++ b/sysdeps/unix/sysv/linux/microblaze/vfork.S

> @@ -28,11 +28,7 @@

>  

>  ENTRY (__vfork)

>  

> -#ifdef __NR_vfork

>  	DO_CALL (vfork, 0)

> -#else

> -	DO_CALL (fork, 0)

> -#endif

>  	addik	r12,r0,-4095

>  	cmpu	r12,r12,r3

>  	bgei	r12,SYSCALL_ERROR_LABEL

>

Patch

diff --git a/sysdeps/unix/sysv/linux/microblaze/vfork.S b/sysdeps/unix/sysv/linux/microblaze/vfork.S
index 7bff659ff3..913aa06e2e 100644
--- a/sysdeps/unix/sysv/linux/microblaze/vfork.S
+++ b/sysdeps/unix/sysv/linux/microblaze/vfork.S
@@ -28,11 +28,7 @@ 
 
 ENTRY (__vfork)
 
-#ifdef __NR_vfork
 	DO_CALL (vfork, 0)
-#else
-	DO_CALL (fork, 0)
-#endif
 	addik	r12,r0,-4095
 	cmpu	r12,r12,r3
 	bgei	r12,SYSCALL_ERROR_LABEL