[02/14] gdb/testsuite: Skip fileio.exp for remote targets

Message ID 20200207150003.8383-3-shahab.vahedi@gmail.com
State New
Headers show
Series
  • Fixes for GDB Testsuites
Related show

Commit Message

Shahab Vahedi Feb. 7, 2020, 2:59 p.m.
From: Anton Kolesov <Anton.Kolesov@synopsys.com>


fileio.exp naively assumes that it will be always running on a target
where application's output is printed into GDB's stdout. Wrong! If
application is run on a gdbserver, then its output is not printed into
GDB stdout.

gdb/testsuite/ChangeLog:
2016-12-16  Anton Kolesov <Anton.Kolesov@synopsys.com>

	* gdb.base/fileio.exp: Skip the test if remote.

Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>

---
 gdb/testsuite/gdb.base/fileio.exp | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.25.0

Comments

Luis Machado Feb. 11, 2020, 7:32 a.m. | #1
Hi,

On 2/7/20 11:59 AM, Shahab Vahedi wrote:
> From: Anton Kolesov <Anton.Kolesov@synopsys.com>

> 

> fileio.exp naively assumes that it will be always running on a target

> where application's output is printed into GDB's stdout. Wrong! If

> application is run on a gdbserver, then its output is not printed into

> GDB stdout.


This relies on 01/14. The test does seem to be skipped when exercising 
the native-gdbserver/native-extended-gdbserver boards.

I think we should clarify 01/14 and merge this patch with that, since 
this is basically just printing some output when the test is skipped.

> 

> gdb/testsuite/ChangeLog:

> 2016-12-16  Anton Kolesov <Anton.Kolesov@synopsys.com>

> 

> 	* gdb.base/fileio.exp: Skip the test if remote.

> 

> Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>

> ---

>   gdb/testsuite/gdb.base/fileio.exp | 3 +++

>   1 file changed, 3 insertions(+)

> 

> diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp

> index 627a685e118d..241552691c38 100644

> --- a/gdb/testsuite/gdb.base/fileio.exp

> +++ b/gdb/testsuite/gdb.base/fileio.exp

> @@ -25,6 +25,9 @@ standard_testfile

>   

>   if {[is_remote target]} {

>       set outdir .

> +    verbose "Skipping fileio.exp because it is truly broken for remote " \

> +	"hosts with gdbservers."

> +    continue

>   } else {

>       set outdir [standard_output_file {}]

>   }

>
Andrew Burgess Feb. 26, 2020, 7:40 p.m. | #2
* Shahab Vahedi <shahab.vahedi@gmail.com> [2020-02-07 15:59:51 +0100]:

> From: Anton Kolesov <Anton.Kolesov@synopsys.com>

> 

> fileio.exp naively assumes that it will be always running on a target

> where application's output is printed into GDB's stdout. Wrong! If

> application is run on a gdbserver, then its output is not printed into

> GDB stdout.

> 

> gdb/testsuite/ChangeLog:

> 2016-12-16  Anton Kolesov <Anton.Kolesov@synopsys.com>

> 

> 	* gdb.base/fileio.exp: Skip the test if remote.


See feedback for patch #1 in this series.  I think that explains why
you are running into this issue too.

Thanks,
Andrew


> 

> Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>

> ---

>  gdb/testsuite/gdb.base/fileio.exp | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp

> index 627a685e118d..241552691c38 100644

> --- a/gdb/testsuite/gdb.base/fileio.exp

> +++ b/gdb/testsuite/gdb.base/fileio.exp

> @@ -25,6 +25,9 @@ standard_testfile

>  

>  if {[is_remote target]} {

>      set outdir .

> +    verbose "Skipping fileio.exp because it is truly broken for remote " \

> +	"hosts with gdbservers."

> +    continue

>  } else {

>      set outdir [standard_output_file {}]

>  }

> -- 

> 2.25.0

>

Patch

diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp
index 627a685e118d..241552691c38 100644
--- a/gdb/testsuite/gdb.base/fileio.exp
+++ b/gdb/testsuite/gdb.base/fileio.exp
@@ -25,6 +25,9 @@  standard_testfile
 
 if {[is_remote target]} {
     set outdir .
+    verbose "Skipping fileio.exp because it is truly broken for remote " \
+	"hosts with gdbservers."
+    continue
 } else {
     set outdir [standard_output_file {}]
 }