xfail x86 gas unique test

Message ID 20200206033233.GX30118@bubble.grove.modra.org
State New
Headers show
Series
  • xfail x86 gas unique test
Related show

Commit Message

Alan Modra Feb. 6, 2020, 3:32 a.m.
This new test needs a few tweaks.

	* testsuite/gas/i386/unique.d: xfail for non-elf targets.
	* testsuite/gas/i386/x86-64-unique.d: Likewise.


-- 
Alan Modra
Australia Development Lab, IBM

Comments

H.J. Lu Feb. 6, 2020, 12:47 p.m. | #1
On Wed, Feb 5, 2020 at 7:32 PM Alan Modra <amodra@gmail.com> wrote:
>

> This new test needs a few tweaks.

>

>         * testsuite/gas/i386/unique.d: xfail for non-elf targets.

>         * testsuite/gas/i386/x86-64-unique.d: Likewise.

>


Sorry I overlooked it.   I checked in this patch to run unique tests
only for ELF targets.

Thanks.

-- 
H.J.
From 986ac31487544ed7553e74f4570f6de83fba1c8d Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 6 Feb 2020 04:44:39 -0800
Subject: [PATCH] x86: Run unique tests only for ELF targets

	* testsuite/gas/i386/i386.exp: Run unique and x86-64-unique
	only for ELF targets.
	* testsuite/gas/i386/unique.d: Don't xfail.
	* testsuite/gas/i386/x86-64-unique.d: Likewise.
---
 gas/ChangeLog                          | 7 +++++++
 gas/testsuite/gas/i386/i386.exp        | 4 ++--
 gas/testsuite/gas/i386/unique.d        | 1 -
 gas/testsuite/gas/i386/x86-64-unique.d | 1 -
 4 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 7c6f245563..8955f53b8b 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,10 @@
+2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* testsuite/gas/i386/i386.exp: Run unique and x86-64-unique
+	only for ELF targets.
+	* testsuite/gas/i386/unique.d: Don't xfail.
+	* testsuite/gas/i386/x86-64-unique.d: Likewise.
+
 2020-02-06  Alan Modra  <amodra@gmail.com>
 
 	* testsuite/gas/i386/unique.d: xfail for non-elf targets.
diff --git a/gas/testsuite/gas/i386/i386.exp b/gas/testsuite/gas/i386/i386.exp
index ffeff0c101..59b14150c2 100644
--- a/gas/testsuite/gas/i386/i386.exp
+++ b/gas/testsuite/gas/i386/i386.exp
@@ -491,7 +491,6 @@ if [expr ([istarget "i*86-*-*"] ||  [istarget "x86_64-*-*"]) && [gas_32_check]]
     run_list_test "inval-pseudo" "-al"
     run_dump_test "nop-1"
     run_dump_test "nop-2"
-    run_dump_test "unique"
     run_dump_test "optimize-1"
     run_dump_test "optimize-1a"
     run_dump_test "optimize-2"
@@ -590,6 +589,7 @@ if [expr ([istarget "i*86-*-*"] ||  [istarget "x86_64-*-*"]) && [gas_32_check]]
 	run_dump_test "nop-4"
 	run_dump_test "nop-5"
 	run_dump_test "nop-6"
+	run_dump_test "unique"
 
 	run_dump_test "evex-no-scale-32"
 	run_dump_test "property-1"
@@ -1051,7 +1051,6 @@ if [expr ([istarget "i*86-*-*"] || [istarget "x86_64-*-*"]) && [gas_64_check]] t
     run_dump_test "x86-64-movd-intel"
     run_dump_test "x86-64-nop-1"
     run_dump_test "x86-64-nop-2"
-    run_dump_test "x86-64-unique"
     run_dump_test "x86-64-movsxd"
     run_dump_test "x86-64-movsxd-intel"
     run_list_test "x86-64-movsxd-inval" "-al"
@@ -1150,6 +1149,7 @@ if [expr ([istarget "i*86-*-*"] || [istarget "x86_64-*-*"]) && [gas_64_check]] t
 	run_dump_test "x86-64-nop-4"
 	run_dump_test "x86-64-nop-5"
 	run_dump_test "x86-64-nop-6"
+	run_dump_test "x86-64-unique"
 
 	run_dump_test "evex-no-scale-64"
 	run_dump_test "x86-64-property-1"
diff --git a/gas/testsuite/gas/i386/unique.d b/gas/testsuite/gas/i386/unique.d
index 11fe90d179..0337733d99 100644
--- a/gas/testsuite/gas/i386/unique.d
+++ b/gas/testsuite/gas/i386/unique.d
@@ -1,6 +1,5 @@
 #objdump: -dw
 #name: i386 unique sections
-#xfail: *-*-darwin *-*-pe *-*-*cygwin* *-*-mingw*
 
 .*: +file format .*
 
diff --git a/gas/testsuite/gas/i386/x86-64-unique.d b/gas/testsuite/gas/i386/x86-64-unique.d
index 59b869377a..4cfd30d5e9 100644
--- a/gas/testsuite/gas/i386/x86-64-unique.d
+++ b/gas/testsuite/gas/i386/x86-64-unique.d
@@ -1,7 +1,6 @@
 #source: unique.s
 #objdump: -dw
 #name: 64bit unique sections
-#xfail: *-*-darwin *-*-pe *-*-*cygwin* *-*-mingw*
 
 .*: +file format .*

Patch

diff --git a/gas/testsuite/gas/i386/unique.d b/gas/testsuite/gas/i386/unique.d
index 0337733d99..11fe90d179 100644
--- a/gas/testsuite/gas/i386/unique.d
+++ b/gas/testsuite/gas/i386/unique.d
@@ -1,5 +1,6 @@ 
 #objdump: -dw
 #name: i386 unique sections
+#xfail: *-*-darwin *-*-pe *-*-*cygwin* *-*-mingw*
 
 .*: +file format .*
 
diff --git a/gas/testsuite/gas/i386/x86-64-unique.d b/gas/testsuite/gas/i386/x86-64-unique.d
index 4cfd30d5e9..59b869377a 100644
--- a/gas/testsuite/gas/i386/x86-64-unique.d
+++ b/gas/testsuite/gas/i386/x86-64-unique.d
@@ -1,6 +1,7 @@ 
 #source: unique.s
 #objdump: -dw
 #name: 64bit unique sections
+#xfail: *-*-darwin *-*-pe *-*-*cygwin* *-*-mingw*
 
 .*: +file format .*