PR25444, Floating point exception in _bfd_elf_compute_section_file_positions

Message ID 20200123092337.GJ4433@bubble.grove.modra.org
State New
Headers show
Series
  • PR25444, Floating point exception in _bfd_elf_compute_section_file_positions
Related show

Commit Message

Alan Modra Jan. 23, 2020, 9:23 a.m.
PR 25444
	* elf.c (assign_file_positions_for_load_sections): Avoid divide
	by zero when p_align is zero.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/bfd/elf.c b/bfd/elf.c
index 08aaab644a..c6a39848b4 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -5755,11 +5755,17 @@  assign_file_positions_for_load_sections (bfd *abfd,
 	    {
 	      p->p_offset = off;
 	      if (no_contents)
-		/* Put meaningless p_offset for PT_LOAD segments
-		   without file contents somewhere within the first
-		   page, in an attempt to not point past EOF.  */
-		p->p_offset = off % (p->p_align > maxpagesize
-				     ? p->p_align : maxpagesize);
+		{
+		  /* Put meaningless p_offset for PT_LOAD segments
+		     without file contents somewhere within the first
+		     page, in an attempt to not point past EOF.  */
+		  bfd_size_type align = maxpagesize;
+		  if (align < p->p_align)
+		    align = p->p_align;
+		  if (align < 1)
+		    align = 1;
+		  p->p_offset = off % align;
+		}
 	    }
 	  else
 	    {